linux-kernel - Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD4jZ3QrOS4fM99s@lizhi-Precision-Tower-5810>
Date: Mon, 2 Jun 2025 18:19:19 -0400
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Alexander Stein <alexander.stein@...tq-group.com>,
	Marek Vasut <marex@...x.de>, Peng Fan <peng.fan@....com>,
	Michael Walle <mwalle@...nel.org>, Fabio Estevam <festevam@...x.de>,
	Markus Niebel <Markus.Niebel@...group.com>,
	Frieder Schrempf <frieder.schrempf@...tron.de>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Max Merchel <Max.Merchel@...tq-group.com>,
	Tim Harvey <tharvey@...eworks.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: arm: lpc: add missed lpc43xx board

On Mon, Jun 02, 2025 at 06:17:49PM +0200, Krzysztof Kozlowski wrote:
> On 02/06/2025 16:06, Frank Li wrote:
> > Add missed legancy lpc43xx board compatible string to fix below CHECK_DTB
>
> typo: legacy
>
> > warnings:
> > arch/arm/boot/dts/nxp/lpc/lpc4337-ciaa.dtb: /: failed to match any schema with compatible: ['ciaa,lpc4337', 'nxp,lpc4337', 'nxp,lpc4350']
>
>
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  .../devicetree/bindings/arm/fsl.yaml          | 23 +++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index d3b5e6923e416..75e46ffe9ba8c 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -1711,6 +1711,29 @@ properties:
> >                - traverse,ten64            # Ten64 Networking Appliance / Board
> >            - const: fsl,ls1088a
> >
> > +      - description: lpc based Boards
> > +        items:
> > +          - enum:
> > +              - ea,lpc4357-developers-kit
> > +              - ciaa,lpc4337
> > +          - enum:
> > +              - nxp,lpc4337
> > +              - nxp,lpc4357
>
> This feels wrong. Why 4337-based board is compatible with 4357 SoC? If
> this was intentional either DTS is wrong or commit msg needs explanation.

I think it is that legacy board dts mess up. I am okay to fix boards's dts.
but I have not hardware to test such changes. There are some risk to toggle
such old boards, such as the uboot may check these comaptible string to do
some fixup. Anyways, these boards is too old.

Do you think it worth to fix dts by take some little risk.

Frank

>
> > +          - const: nxp,lpc4350
> > +
> Best regards,
> Krzysztof