linux-kernel - Re: [PATCH AUTOSEL 6.15 101/110] ALSA: seq: Remove unused snd_seq_queue_client_leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aDznZgej_QbaalP0@gallifrey>
Date: Sun, 1 Jun 2025 23:51:02 +0000
From: "Dr. David Alan Gilbert" <linux@...blig.org>
To: Sasha Levin <sashal@...nel.org>
Cc: patches@...ts.linux.dev, stable@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>, perex@...ex.cz, tiwai@...e.com,
	yuehaibing@...wei.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.15 101/110] ALSA: seq: Remove unused
 snd_seq_queue_client_leave_cells

* Sasha Levin (sashal@...nel.org) wrote:

Hi Sasha,

> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> [ Upstream commit 81ea9e92941091bb3178d49e63b13bf4df2ee46b ]
> 
> The last use of snd_seq_queue_client_leave_cells() was removed in 2018
> by
> commit 85d59b57be59 ("ALSA: seq: Remove superfluous
> snd_seq_queue_client_leave_cells() call")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> Link: https://patch.msgid.link/20250502235219.1000429-4-linux@treblig.org
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
> 
> NO This commit should not be backported to stable kernel trees for
> several reasons: 

I'd agree with that big fat NO - unless it makes your life easier backporting
a big pile of other stuff.
I'm a bit curious about:
  a) How it got picked up by autosel - I'm quite careful not to include
     'fixes' tags to avoid them getting picked up.
  b) Given it's got a big fat no, why is it posted here?

Dave


**1. This is a code cleanup, not a bug fix** The commit
> removes dead code (`snd_seq_queue_client_leave_cells()`) that hasn't
> been used since 2018. The commit message explicitly states this function
> was already removed from use by commit 85d59b57be59 in 2018, and this
> commit is simply cleaning up the unused function definition. This is
> purely a maintenance/cleanup change with no functional impact. **2. No
> user-visible impact or bug being fixed** The removed function
> `snd_seq_queue_client_leave_cells()` was already unused, so removing it
> doesn't fix any existing bugs, security issues, or user-reported
> problems. The code changes show: - Removal of the function
> implementation from `sound/core/seq/seq_queue.c` (lines that iterate
> through queues and call `snd_seq_prioq_leave()`) - Removal of the
> function declaration from `sound/core/seq/seq_queue.h` **3. Follows
> pattern of similar non-backported commits** Looking at the similar
> commits provided: - **Similar Commit #1**: Removed superfluous function
> call - Status: NO - **Similar Commit #2**: Removed useless function -
> Status: NO - **Similar Commit #4**: Removed unused declarations -
> Status: NO - **Similar Commit #5**: Code refactoring with no functional
> changes - Status: NO Only **Similar Commit #3** was backported (Status:
> YES), and that was because it fixed an actual race condition bug that
> could cause long stalls, not because it was removing unused code. **4.
> Stable tree criteria not met** Stable kernel backports should focus on:
> - Important bug fixes that affect users - Security fixes - Critical
> functionality issues This commit doesn't meet any of these criteria.
> It's purely cosmetic code cleanup that removes dead code without
> changing any runtime behavior. **5. Risk vs. benefit analysis** While
> the risk of regression is minimal since the function was unused, there's
> no benefit to users of stable kernels from this change. Stable trees
> should minimize churn and only include changes that provide tangible
> benefits to users. The commit represents good housekeeping for the
> mainline kernel but doesn't provide the type of user-impacting fix that
> justifies inclusion in stable kernel trees.
> 
>  sound/core/seq/seq_queue.c | 16 ----------------
>  sound/core/seq/seq_queue.h |  1 -
>  2 files changed, 17 deletions(-)
> 
> diff --git a/sound/core/seq/seq_queue.c b/sound/core/seq/seq_queue.c
> index 5df26788dda41..10add922323da 100644
> --- a/sound/core/seq/seq_queue.c
> +++ b/sound/core/seq/seq_queue.c
> @@ -564,22 +564,6 @@ void snd_seq_queue_client_leave(int client)
>  
>  /*----------------------------------------------------------------*/
>  
> -/* remove cells from all queues */
> -void snd_seq_queue_client_leave_cells(int client)
> -{
> -	int i;
> -	struct snd_seq_queue *q;
> -
> -	for (i = 0; i < SNDRV_SEQ_MAX_QUEUES; i++) {
> -		q = queueptr(i);
> -		if (!q)
> -			continue;
> -		snd_seq_prioq_leave(q->tickq, client, 0);
> -		snd_seq_prioq_leave(q->timeq, client, 0);
> -		queuefree(q);
> -	}
> -}
> -
>  /* remove cells based on flush criteria */
>  void snd_seq_queue_remove_cells(int client, struct snd_seq_remove_events *info)
>  {
> diff --git a/sound/core/seq/seq_queue.h b/sound/core/seq/seq_queue.h
> index 74cc31aacdac1..b81379c9af43e 100644
> --- a/sound/core/seq/seq_queue.h
> +++ b/sound/core/seq/seq_queue.h
> @@ -66,7 +66,6 @@ void snd_seq_queue_client_leave(int client);
>  int snd_seq_enqueue_event(struct snd_seq_event_cell *cell, int atomic, int hop);
>  
>  /* Remove events */
> -void snd_seq_queue_client_leave_cells(int client);
>  void snd_seq_queue_remove_cells(int client, struct snd_seq_remove_events *info);
>  
>  /* return pointer to queue structure for specified id */
> -- 
> 2.39.5
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/