linux-kernel - Re: [PATCH v2 3/4] dt-bindings: input: Add TouchNetix axiom touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93434285-ebef-4039-9a7a-e5786fd8bcd2@kernel.org>
Date: Mon, 2 Jun 2025 10:17:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Marco Felsch <m.felsch@...gutronix.de>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
 <russ.weight@...ux.dev>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Kamel Bouhara <kamel.bouhara@...tlin.com>,
 Marco Felsch <kernel@...gutronix.de>, Henrik Rydberg <rydberg@...math.org>,
 Danilo Krummrich <dakr@...hat.com>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: input: Add TouchNetix axiom
 touchscreen

On 30/05/2025 10:45, Marco Felsch wrote:
>>> +
>>> +  interrupts:
>>> +    maxItems: 1
>>> +
>>> +  reset-gpios:
>>> +    maxItems: 1
>>> +
>>> +  panel: true
>>
>> So that was the reason of dropping tag?
>> https://lore.kernel.org/lkml/821ce1d4-bc15-4764-bbe0-315c57e8536e@linaro.org/
>>
>> Anyway, drop the property. Redundant.
> 
> Why is this redundant? The touchscreen.yaml defines it but I need to

It is redundant, because it has ZERO effect. The presence of this
property or lack of it changes nothing. Binding has exactly the same
meaning. Binding behaves exactly the same way in validation/checks. Zero
difference. If there is a difference, please paste checks results.

> request it? At least I understood it that way and all other users of
> this property do it same way. Same is true for all the touchscreen-*

And these users end the binding with additionalProps, right? So that's
the difference.

> properties definied in touchscreen.yaml.
> 
> Regards,
>   Marco

Best regards,
Krzysztof