linux-kernel - Re: [PATCH] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf4f1e06-f692-43bf-9261-30585a1427d7@oracle.com>
Date: Mon, 2 Jun 2025 14:20:16 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: bcf@...gle.com, joshwash@...gle.com, willemb@...gle.com,
        pkaligineedi@...gle.com, pabeni@...hat.com, kuba@...nel.org,
        jeroendb@...gle.com, hramamurthy@...gle.com, andrew+netdev@...n.ch,
        davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] gve: add missing NULL check for
 gve_alloc_pending_packet() in TX DQO

Hi Mina,

On 02-06-2025 01:21, ALOK TIWARI wrote:
> Patch itself looks good to me, but if you can, please designate it to
> the net tree by prefixing the patch with `[PATCH net v2]` as mentioned
> in our docs:
> 
> https://urldefense.com/v3/__https://docs.kernel.org/process/maintainer- 
> netdev.html__;!!ACWV5N9M2RV99hQ!JPpnRT9itx84rhzAaeGelVD- 
> bnJR8vFksx2OjGzAKZWf_A6o8hEY0CUMMUO_NuSStcCyBGnvhoJAJlADszR4D_aj$
> 
> Also, if possible, add `Fixes: commit a57e5de476be ("gve: DQO: Add TX
> path")` to give it a chance to get picked up by stable trees.

I believe commit a6fb8d5a8b69 is a more natural and appropriate 
candidate for the Fixes tag compared to a57e5de476be
What’s your take on this, Mina?

> 
> With that:
> 
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>


Thanks,
Alok