linux-kernel - Re: [PATCH v5 0/2] Add support for Firefly Station-M3/ROC-RK3588S-PC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce936fc9-f1d8-4f6c-a188-28a90481886f@cherry.de>
Date: Mon, 2 Jun 2025 12:09:49 +0200
From: Quentin Schulz <quentin.schulz@...rry.de>
To: "Rob Herring (Arm)" <robh@...nel.org>, Hsun Lai <i@...insx.cn>
Cc: heiko@...ech.de, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 inindev@...il.com, sfr@...b.auug.org.au, conor+dt@...nel.org,
 linux-kernel@...r.kernel.org, krzk+dt@...nel.org,
 nicolas.frattaroli@...labora.com, krzysztof.kozlowski@...aro.org,
 andrew@...n.ch, jonas@...boo.se
Subject: Re: [PATCH v5 0/2] Add support for Firefly Station-M3/ROC-RK3588S-PC

Hi Rob,

On 5/30/25 2:52 PM, Rob Herring (Arm) wrote:
> 
> On Fri, 30 May 2025 11:10:44 +0800, Hsun Lai wrote:
>> This series add support for Firefly Station-M3/ROC-RK3588S-PC.
>>
>> Info of device can be found at:
>> https://wiki.t-firefly.com/en/Station-M3/index.html
>>
>> Changes in v5:
>> - Make led-1 off by default (Chukun Pan, v4)
>> - Add color settings for led (Chukun Pan, v4)
>> - Remove vcc5v0_usbdcin
>> - Put enable/gpio before regulator (Chukun Pan, v4)
>> - Remove always-on and boot-on from vcc5v0_host (Chukun Pan, v4)
>> - Update the name of vbus_typec (Chukun Pan, v4)
>> - Remove always-on and boot-on from vbus5v0_typec (Chukun Pan, v4)
>> - Put pinctrl-names before pinctrl-0 (Chukun Pan, v4)
>> - Remove usb_con node
>> - Remove extra blank lines (Chukun Pan, v4)
>> - Add phy-supply for u2phy3_host (Chukun Pan, v4)
>>
>> Changes in v4:
>> - Update the name of the regulator
>> - Remove the i2s5_8ch node
>>
>> Changes in v3:
>> - Update the name of leds
>> - Add more cpu nodes
>> - Update mdio compatible
>> - Fix the order in the node
>> - Add the default serial port(uart2)
>> - Patch 1: Reviewed-by: Quentin Schulz <quentin.schulz@...rry.de>
>>
>> Changes in v2:
>> - Fix rgmii delays
>>
>> Changes in v1:
>> - Add support for Firefly ROC-RK3588S-PC
>>
>> Hsun Lai (2):
>>    dt-bindings: arm: rockchip: Add Firefly ROC-RK3588S-PC
>>    arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC
>>
>>   .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>>   arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>>   .../boot/dts/rockchip/rk3588s-roc-pc.dts      | 838 ++++++++++++++++++
>>   3 files changed, 844 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>   Base: attempting to guess base-commit...
>   Base: remotes/arm-soc/rockchip/dt64-31-ge463625af7f9 (exact match)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250530031046.166202-1-i@...insx.cn:
> 
> arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dtb: /edp@...c0000: failed to match any schema with compatible: ['rockchip,rk3588-edp']
> 

I tried to replicate on top of master 
(24de2b9da3e28df323c1e096538ae1e035751adf) but couldn't, so I guess we 
can simply ignore this warning?

Cheers,
Quentin