[<prev] [next>] [day] [month] [year] [list]
Message-ID: <f536ceb2-6794-4877-83d1-898e56840c0c@kernel.org>
Date: Mon, 2 Jun 2025 13:18:43 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Akhil R <akhilrajeev@...dia.com>,
"andi.shyti@...nel.org" <andi.shyti@...nel.org>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
Jon Hunter <jonathanh@...dia.com>, Laxman Dewangan <ldewangan@...dia.com>,
"digetx@...il.com" <digetx@...il.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the
required properties
On 02/06/2025 13:10, Akhil R wrote:
>>
>>> + Module reset. This property is optional for controllers in Tegra194 and later
>>
>> Your binding says Tegra210 requires it, but 210 feels like something
>> later than 194. Maybe that's obvious for people knowing that device?
>
> Tegra210 is in fact an older device than T194. I will probably mention the chip names
> instead of “later” in the next version.
>
>>
>> Anyway, please wrap at 80 (see kernel coding style).
>
> Okay. Will update.
> checkpatch.pl don’t warn now till 100 characters. I thought it was updated.
Checkpatch is a tool, not coding style. Coding style document describes
the coding style.
Best regards,
Krzysztof
Powered by blists - more mailing lists