[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aD2hBF23eNeEJJYj@kuha.fi.intel.com>
Date: Mon, 2 Jun 2025 16:03:00 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Raag Jadav <raag.jadav@...el.com>
Cc: Lucas De Marchi <lucas.demarchi@...el.com>,
Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@...el.com>,
Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
"Tauro, Riana" <riana.tauro@...el.com>,
"Adatrao, Srinivasa" <srinivasa.adatrao@...el.com>,
intel-xe@...ts.freedesktop.org, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org,
"Michael J. Ruhl" <michael.j.ruhl@...el.com>
Subject: Re: [PATCH v1 2/2] drm/xe: Support for I2C attached MCUs
On Fri, May 30, 2025 at 07:02:23PM +0300, Raag Jadav wrote:
> On Fri, May 30, 2025 at 05:17:44PM +0300, Heikki Krogerus wrote:
> > Adding adaption/glue layer where the I2C host adapter
> > (Synopsys DesignWare I2C adapter) and the I2C clients (the
> > microcontroller units) are enumerated.
> >
> > The microcontroller units (MCU) that are attached to the GPU
> > depend on the OEM. The initially supported MCU will be the
> > Add-In Management Controller (AMC).
>
> ...
>
> > diff --git a/drivers/gpu/drm/xe/regs/xe_i2c_regs.h b/drivers/gpu/drm/xe/regs/xe_i2c_regs.h
> > new file mode 100644
> > index 000000000000..2acb55eeef0d
> > --- /dev/null
> > +++ b/drivers/gpu/drm/xe/regs/xe_i2c_regs.h
> > @@ -0,0 +1,16 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _XE_I2C_REGS_H_
> > +#define _XE_I2C_REGS_H_
> > +
> > +#include "xe_reg_defs.h"
> > +
> > +#define SOC_BASE 0x280000
>
> I just noticed we already have this in xe_pmt.h, so let's not duplicate
> it. Perhaps move it to a common header (xe_regs.h) and reuse it in both
> places?
Makes sense to me. If no objections, I'll move it there in v2.
thanks,
> > +#define I2C_CONFIG_SPACE_OFFSET (SOC_BASE + 0xf6000)
> > +#define I2C_MEM_SPACE_OFFSET (SOC_BASE + 0xf7400)
> > +#define I2C_BRIDGE_OFFSET (SOC_BASE + 0xd9000)
> > +
> > +#define CLIENT_DISC_COOKIE XE_REG(SOC_BASE + 0x0164)
> > +#define CLIENT_DISC_ADDRESS XE_REG(SOC_BASE + 0x0168)
> > +
> > +#endif /* _XE_I2C_REGS_H_ */
--
heikki
Powered by blists - more mailing lists