linux-kernel - Re: [PATCH RFC net-next] net: phylink: always config mac for (delayed) phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2894a781-4d4b-4e3c-9f4e-7c1f04122f8a@0upti.me>
Date: Mon, 2 Jun 2025 16:00:14 +0300
From: Ilya K <me@...ti.me>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Eric Woudstra <ericwouds@...il.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Frank Wunderlich <frank-w@...lic-files.de>,
 Daniel Golle <daniel@...rotopia.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, bridge@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH RFC net-next] net: phylink: always config mac for
 (delayed) phy

On 2025-06-02 11:48, Russell King (Oracle) wrote:
> On Mon, Jun 02, 2025 at 10:19:22AM +0300, Ilya K wrote:
>> On 2025-01-09 12:15, Russell King (Oracle) wrote:
>>> On Thu, Jan 09, 2025 at 09:56:17AM +0100, Eric Woudstra wrote:
>>> I'll look at what we can do for this today.
>> Hey folks, don't really want to necrobump this, but the original hack patch is the only way I can get my weirdo Realtek (noticing a pattern here) GPON modem-on-a-stick to probe at 2500base-x on a BPi-R4. I've actually tracked down the issue myself and wrote basically the same patch first :( Is there anything I can do (with my extremely limited phylink understanding) to help move this forward so other people don't have to suffer like I did?
> 
> There were two issues that were identified. The first was that when in
> 2500Base-X mode, the PCS wasn't reporting link-up. That was addressed
> by the patch series:
> 
> Z4TbR93B-X8A8iHe@...ll.armlinux.org.uk
> 
> then, the replacement for Eric's patch was:
> 
> E1tYhxp-001FHf-Ac@...-PC.armlinux.org.uk
> 
> So the problem should be solved with these applied, as when the PHY is
> attached, "changed" will always be true, which is in effect what Eric's
> patch was doing, but in a cleaner way.
> 
> Please confirm that you have all six patches applied.
> 

That's weird, because I do have all the patches applied. I think this may have been broken by the pcs_inband_caps changes, because without the patch I'm just getting "autoneg setting not compatible with PCS", after which it bails, when it should really reconfigure the MAC instead.

(resending because I replied instead of reply-all by accident)