linux-kernel - Re: [PATCH v3] rust: doc: Clean up formatting in io.rs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72ncQxzmQkOVo9sNcLvZEWiN5GFOS4Yg6w6NUKMrtX2AVw@mail.gmail.com>
Date: Mon, 2 Jun 2025 16:18:55 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Sai Vishnu <saivishnu725@...il.com>
Cc: Greg KH <gregkh@...uxfoundation.org>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, alex.gaynor@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	Benno Lossin <lossin@...nel.org>, a.hindborg@...nel.org, aliceryhl@...gle.com, 
	tmgross@...ch.edu, dakr@...nel.org, daniel.almeida@...labora.com, 
	me@...enk.dev
Subject: Re: [PATCH v3] rust: doc: Clean up formatting in io.rs

On Mon, Jun 2, 2025 at 1:11 PM Sai Vishnu <saivishnu725@...il.com> wrote:
>
> Is it the one below the Signed off by line? To get the complete picture:

Yes, after that and before the diffstat -- please check some examples
in the list as Greg suggests.

> Additionally, I suppose the `base-commit` tag should also be placed in
> 3 (above/below Signed-off-by), as it was added to the very end by
> `git` when generating the patch.

Where Git adds it should be fine :)

In fact, if you have a good Git commit, and you use the right flags,
then Git can take care of essentially everything for you, i.e. you
should not generally need to edit much (or anything at all), though
you may or may not want to use some of its features, e.g. notes and
branch descriptions. Please take a look at `man git-format-patch`.

Thanks!

Cheers,
Miguel