linux-kernel - Re: [PATCH 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5019298.31r3eYUQgx@steina-w>
Date: Mon, 02 Jun 2025 16:28:55 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Gregor Herburger <gregor.herburger@...group.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux@...tq-group.com
Subject:
 Re: [PATCH 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind
 devicetrees

Am Freitag, 30. Mai 2025, 18:17:00 CEST schrieb Frank Li:
> ********************
> Achtung externe E-Mail: Öffnen Sie Anhänge und Links nur, wenn Sie wissen, dass diese aus einer sicheren Quelle stammen und sicher sind. Leiten Sie die E-Mail im Zweifelsfall zur Prüfung an den IT-Helpdesk weiter.
> Attention external email: Open attachments and links only if you know that they are from a secure source and are safe. In doubt forward the email to the IT-Helpdesk to check it.
> ********************
> 
> On Fri, May 30, 2025 at 08:29:27AM +0200, Alexander Stein wrote:
> > Hi Frank,
> >
> > Am Mittwoch, 28. Mai 2025, 17:35:52 CEST schrieb Frank Li:
> > > On Tue, May 27, 2025 at 08:03:55AM +0200, Alexander Stein wrote:
> > > > From: Gregor Herburger <gregor.herburger@...group.com>
> > > >
> > > > Add device trees for the MBLS1028A and the MBLS1028A-IND and the SoM
> > > > TQMLS1028A.
> > > >
> > > > Signed-off-by: Gregor Herburger <gregor.herburger@...group.com>
> > > > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> > > > ---
> > > >  arch/arm64/boot/dts/freescale/Makefile        |   2 +
> > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a-ind.dts  |  68 ++++
> > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dts      | 118 +++++++
> > > >  .../fsl-ls1028a-tqmls1028a-mbls1028a.dtsi     | 291 ++++++++++++++++++
> > > >  .../dts/freescale/fsl-ls1028a-tqmls1028a.dtsi | 117 +++++++
> > >
> > > New dts file, suggest run https://github.com/lznuaa/dt-format to nice order
> >
> > Thanks for the suggestions. It does some improvements, but I also disagree
> > with a lot of proposed changes:
> > * Wrong indent of SPDX tag
> > * model property should come first IMHO
> > * {gpio,interrupt}-controller should come before #{gpio,interrupt}-cells
> 
> I checked code, it is specific rule to make -cells before -controller. It
> should come from previous review comments.
> 
> Do you have document or mail list require -controller before --cells ?

There is Documentation/devicetree/bindings/interrupt-controller/interrupts.txt.
While not exactly saying anything about property order, "interrupt-controller"
is stated in the very first sentence.
Also from a readers perspective having "-controller" first seems
reasonable, IMHO. "-cells" is necessary because it is a controller.

Best regards
Alexander

> Frank
> 
> > * gpio-hog property should come first in a hog node
> > * sorting gpio-hog nodes by name instead of line number seems wrong
> >
> > There are some more bogus changes, so I'll skip this tool for now.
> >
> > Thanks & best regards
> > Alexander
> >
> > > Frank
> > > [...]
> > --
> > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> > Amtsgericht München, HRB 105018
> > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> > http://www.tq-group.com/
> >
> >
> 
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/