linux-kernel - Re: [PATCH 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65f5e6e9-f02e-4374-9f17-bc833fac2316@lunn.ch>
Date: Mon, 2 Jun 2025 16:50:00 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Frank Li <Frank.Li@....com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: net: convert nxp,lpc1850-dwmac.txt to
 yaml format

> +examples:
> +  - |
> +    #include <dt-bindings/clock/lpc18xx-ccu.h>
> +
> +    ethernet@...10000 {
> +        compatible = "nxp,lpc1850-dwmac", "snps,dwmac-3.611", "snps,dwmac";
> +        reg = <0x40010000 0x2000>;
> +        interrupts = <5>;
> +        interrupt-names = "macirq";
> +        clocks = <&ccu1 CLK_CPU_ETHERNET>;
> +        clock-names = "stmmaceth";
> +        resets = <&rgu 22>;
> +        reset-names = "stmmaceth";
> +        phy-mode = "rgmii";

Please don't use 'rgmii' in an example, because it is 99% of the time
wrong. You are just encouraging developers to copy/paste this into
real DT blobs, and then i need to point out it is wrong. Use
'rgmii-id', which is much more likely to be correct.

	Andrew