linux-kernel - Re: [PATCH 1/2] fs: Provide function that allocates a secure anonymous inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD5_hL-caOZjSk8x@infradead.org>
Date: Mon, 2 Jun 2025 21:52:20 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Ackerley Tng <ackerleytng@...gle.com>
Cc: kvm@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, linux-fsdevel@...r.kernel.org, aik@....com,
	ajones@...tanamicro.com, akpm@...ux-foundation.org,
	amoorthy@...gle.com, anthony.yznaga@...cle.com, anup@...infault.org,
	aou@...s.berkeley.edu, bfoster@...hat.com,
	binbin.wu@...ux.intel.com, brauner@...nel.org,
	catalin.marinas@....com, chao.p.peng@...el.com,
	chenhuacai@...nel.org, dave.hansen@...el.com, david@...hat.com,
	dmatlack@...gle.com, dwmw@...zon.co.uk, erdemaktas@...gle.com,
	fan.du@...el.com, fvdl@...gle.com, graf@...zon.com,
	haibo1.xu@...el.com, hch@...radead.org, hughd@...gle.com,
	ira.weiny@...el.com, isaku.yamahata@...el.com, jack@...e.cz,
	james.morse@....com, jarkko@...nel.org, jgg@...pe.ca,
	jgowans@...zon.com, jhubbard@...dia.com, jroedel@...e.de,
	jthoughton@...gle.com, jun.miao@...el.com, kai.huang@...el.com,
	keirf@...gle.com, kent.overstreet@...ux.dev,
	kirill.shutemov@...el.com, liam.merwick@...cle.com,
	maciej.wieczor-retman@...el.com, mail@...iej.szmigiero.name,
	maz@...nel.org, mic@...ikod.net, michael.roth@....com,
	mpe@...erman.id.au, muchun.song@...ux.dev, nikunj@....com,
	nsaenz@...zon.es, oliver.upton@...ux.dev, palmer@...belt.com,
	pankaj.gupta@....com, paul.walmsley@...ive.com, pbonzini@...hat.com,
	pdurrant@...zon.co.uk, peterx@...hat.com, pgonda@...gle.com,
	pvorel@...e.cz, qperret@...gle.com, quic_cvanscha@...cinc.com,
	quic_eberman@...cinc.com, quic_mnalajal@...cinc.com,
	quic_pderrin@...cinc.com, quic_pheragu@...cinc.com,
	quic_svaddagi@...cinc.com, quic_tsoni@...cinc.com,
	richard.weiyang@...il.com, rick.p.edgecombe@...el.com,
	rientjes@...gle.com, roypat@...zon.co.uk, rppt@...nel.org,
	seanjc@...gle.com, shuah@...nel.org, steven.price@....com,
	steven.sistare@...cle.com, suzuki.poulose@....com, tabba@...gle.com,
	thomas.lendacky@....com, vannapurve@...gle.com, vbabka@...e.cz,
	viro@...iv.linux.org.uk, vkuznets@...hat.com, wei.w.wang@...el.com,
	will@...nel.org, willy@...radead.org, xiaoyao.li@...el.com,
	yan.y.zhao@...el.com, yilun.xu@...el.com, yuzenghui@...wei.com,
	zhiquan1.li@...el.com
Subject: Re: [PATCH 1/2] fs: Provide function that allocates a secure
 anonymous inode

On Mon, Jun 02, 2025 at 12:17:54PM -0700, Ackerley Tng wrote:
> +struct inode *alloc_anon_secure_inode(struct super_block *s, const char *name)
> +{
> +	return anon_inode_make_secure_inode(s, name, NULL, true);
> +}
> +EXPORT_SYMBOL_GPL(alloc_anon_secure_inode);

What is "secure" about this inode?

A kerneldoc explaining that would probably help.

> +extern struct inode *alloc_anon_secure_inode(struct super_block *, const char *);

No need for the extern here.  Spelling out the parameter names in
protypes is nice, though. (and fix the long line while you're at it).