linux-kernel - Re: [PATCH v2 3/3] hwmon: (amc6821) Add cooling device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ukezxbl6x62mmdgxmzkjsb3mtg6tz5ecyib3cu6y7iavpr7257@vvxmy7vawpp5>
Date: Tue, 3 Jun 2025 15:46:32 -0300
From: 
	João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>
To: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Farouk Bouabid <farouk.bouabid@...rry.de>, 
	Quentin Schulz <quentin.schulz@...rry.de>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	João Paulo Gonçalves <joao.goncalves@...adex.com>
Subject: Re: [PATCH v2 3/3] hwmon: (amc6821) Add cooling device support

Hi all,

> +
> +	if (IS_ENABLED(CONFIG_THERMAL) && fan_np && data->fan_cooling_levels)
> +		return PTR_ERR_OR_ZERO(devm_thermal_of_cooling_device_register(dev,
> +									       fan_np,
> +									       client->name,
> +									       data,
> +									       &amc6821_cooling_ops));
> +
> +	return 0;
>  }

There's a mistake here: `fan_np` is used after `of_node_put(fan_np)`. I will
address it in v3.

Sorry for the inconvenience.

Best Regards,
João Paulo Gonçalves