linux-kernel - Re: [PATCH v3 5/8] riscv: dts: thead: th1520: Add missing reset controller header include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1906dee9-5fe2-4d85-b218-2b669a03ecf7@kernel.org>
Date: Tue, 3 Jun 2025 20:49:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Drew Fustini <drew@...7.com>, Guo Ren <guoren@...nel.org>,
 Fu Wei <wefu@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Philipp Zabel <p.zabel@...gutronix.de>, Frank Binns
 <frank.binns@...tec.com>, Matt Coster <matt.coster@...tec.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, Ulf Hansson <ulf.hansson@...aro.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3 5/8] riscv: dts: thead: th1520: Add missing reset
 controller header include

On 03/06/2025 20:26, Michal Wilczynski wrote:
> 
> 
> On 6/3/25 15:20, Krzysztof Kozlowski wrote:
>> On Fri, May 30, 2025 at 12:23:52AM GMT, Michal Wilczynski wrote:
>>> TH1520_RESET_ID_GPU_CLKGEN and TH1520_RESET_ID_GPU are required for GPU
>>> power sequencing to work.  To make these symbols available, add the
>>> necessary include for the T-HEAD TH1520 reset controller bindings.
>>
>> How would it compile/build without it? If there are no users, then do
>> not add unused header just to add it.
> 
> The patch 7 in the series need it, so I've added the header.

Then this should be squashed with patch 7. Adding unused header is not a
logical change on its own.

Best regards,
Krzysztof