[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <b2225fa4-ffdb-4156-afb9-561484d6d78e@de.bosch.com>
Date: Tue, 3 Jun 2025 07:10:49 +0200
From: Dirk Behme <dirk.behme@...bosch.com>
To: Remo Senekowitsch <remo@...nzli.dev>, Rob Herring <robh@...nel.org>,
Saravana Kannan <saravanak@...gle.com>, Miguel Ojeda <ojeda@...nel.org>, Alex
Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo
<gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>, "Andreas
Hindborg" <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, "Trevor
Gross" <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, "Greg
Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki"
<rafael@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v7 0/9] More Rust bindings for device property reads
Hi Remo,
On 30/05/2025 21:28, Remo Senekowitsch wrote:
> changes in v7:
> * Fix a typo in a commit message.
> * Fix bug in `FwNode::display_path`. I took a slightly different
> approach than the one suggested, using `Either` to handle the
> owned and borrowed case. That also removes the conditional
> `fwnode_handle_put` at the end.
> * Move `FwNode::from_raw` to the commit which first introduces the
> `FwNode` abstraction. It is needed in an earlier commit than before
> and I think it fits better there.
>
> Best regards,
> Remo
>
> Remo Senekowitsch (9):
> rust: device: Create FwNode abstraction for accessing device
> properties
> rust: device: Enable accessing the FwNode of a Device
> rust: device: Add property_present() to FwNode
> rust: device: Enable printing fwnode name and path
> rust: device: Introduce PropertyGuard
> rust: device: Implement accessors for firmware properties
> rust: device: Add child accessor and iterator
> rust: device: Add property_get_reference_args
> samples: rust: platform: Add property read examples
>
> MAINTAINERS | 1 +
> drivers/of/unittest-data/tests-platform.dtsi | 3 +
> rust/helpers/helpers.c | 1 +
> rust/helpers/property.c | 8 +
> rust/kernel/device.rs | 17 +
> rust/kernel/device/property.rs | 590 +++++++++++++++++++
> samples/rust/rust_driver_platform.rs | 60 +-
> 7 files changed, 679 insertions(+), 1 deletion(-)
> create mode 100644 rust/helpers/property.c
> create mode 100644 rust/kernel/device/property.rs
I have tested this series with x86/Qemu running the sample. And the same
on real custom ARM64 hardware. Additionally, I ported a custom driver on
ARM64 to use this (well, it just uses the trivial
property_read().required_by()). So if it helps
Tested-by: Dirk Behme <dirk.behme@...bosch.com>
for the whole series.
Btw, many thanks for working on this!
Dirk
Powered by blists - more mailing lists