linux-kernel - Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aD6W1JRDbUKt0m7j@kernel.org>
Date: Tue, 3 Jun 2025 09:31:48 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...hat.com>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	"Liam R. Howlett" <Liam.Howlett@...cle.com>,
	Vlastimil Babka <vbabka@...e.cz>,
	Suren Baghdasaryan <surenb@...gle.com>,
	Michal Hocko <mhocko@...e.com>, Zi Yan <ziy@...dia.com>,
	Juan Yescas <jyescas@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Kconfig: Use verb *use* in plural form in description

On Tue, Jun 03, 2025 at 08:13:03AM +0200, Paul Menzel wrote:
> *workloads* is plural requiring the verb *use* in plural form.
> 
> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
> Signed-off-by: Paul Menzel <pmenzel@...gen.mpg.de>

Acked-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

> ---
> Reading the sentence it feels like, something is missing before the
> *please*, but I am no native speaker.
> 
>  mm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/Kconfig b/mm/Kconfig
> index f8bb8f070d0d..e3a07687ed0b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -1022,7 +1022,7 @@ config PAGE_BLOCK_ORDER
>  	  or MAX_PAGE_ORDER.
>  
>  	  Reducing pageblock order can negatively impact THP generation
> -	  success rate. If your workloads uses THP heavily, please use this
> +	  success rate. If your workloads use THP heavily, please use this
>  	  option with caution.
>  
>  	  Don't change if unsure.
> -- 
> 2.49.0
> 

-- 
Sincerely yours,
Mike.