linux-kernel - Re: [PATCH 1/1] dt-bindings: gpio: convert gpio-74xx-mmio.txt to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b22ca31-4a6c-4f94-8623-9b0448699eaa@kernel.org>
Date: Tue, 3 Jun 2025 09:03:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, "open list:GPIO SUBSYSTEM"
 <linux-gpio@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: gpio: convert gpio-74xx-mmio.txt to yaml
 format

On 02/06/2025 16:50, Frank Li wrote:
> Convert gpio-74xx-mmio.txt to yaml format.
> 
> Additional changes:
> - remove label in example.

No need to mention trivial changes in example. We ask to describe
changes in the BINDING.

> 
> Signed-off-by: Frank Li <Frank.Li@....com

...

> new file mode 100644
> index 0000000000000..2ec33248dfce1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/ti,7416374.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/ti,7416374.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: 74XX MMIO GPIO driver

TI 74XX MMIO GPIO Controller

> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,741g125 # for 741G125 (1-bit Input),
> +      - ti,741g174 # for 741G74 (1-bit Output),
> +      - ti,742g125 # for 742G125 (2-bit Input),
> +      - ti,7474    # for 7474 (2-bit Output),
> +      - ti,74125   # for 74125 (4-bit Input),
> +      - ti,74175   # for 74175 (4-bit Output),
> +      - ti,74365   # for 74365 (6-bit Input),
> +      - ti,74174   # for 74174 (6-bit Output),
> +      - ti,74244   # for 74244 (8-bit Input),
> +      - ti,74273   # for 74273 (8-bit Output),
> +      - ti,741624  # for 741624 (16-bit Input),
> +      - ti,7416374 # for 7416374 (16-bit Output).
> +
> +  reg:
> +    maxItems: 1
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +    description: |
> +      The first cell is the pin number and
> +      the second cell is used to specify the GPIO polarity:
> +        0 = Active High,
> +        1 = Active Low.
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'
> +
> +additionalProperties: true

This cannot be true.


Best regards,
Krzysztof