linux-kernel - Re: [PATCH v2 01/46] panel/orisetech-otm8009a: Use refcounted allocation in place of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWsGVNsm_WdiZ2hNuErrUUaj49SN_ROr-_KfEWW63omTw@mail.gmail.com>
Date: Tue, 3 Jun 2025 09:10:59 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Anusha Srivatsa <asrivats@...hat.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Robert Chiras <robert.chiras@....com>, Linus Walleij <linus.walleij@...aro.org>, 
	Markuss Broks <markuss.broks@...il.com>, Artur Weber <aweber.kernel@...il.com>, 
	Dzmitry Sankouski <dsankouski@...il.com>, Jagan Teki <jagan@...rulasolutions.com>, 
	Guido Günther <agx@...xcpu.org>, 
	Purism Kernel Team <kernel@...i.sm>, Ondrej Jirman <megi@....cz>, Sasha Finkelstein <fnkl.kernel@...il.com>, 
	Janne Grunau <j@...nau.net>, Michael Trimarchi <michael@...rulasolutions.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, asahi@...ts.linux.dev
Subject: Re: [PATCH v2 01/46] panel/orisetech-otm8009a: Use refcounted
 allocation in place of devm_kzalloc()

Hi Anusha,

On Fri, 30 May 2025 at 20:28, Anusha Srivatsa <asrivats@...hat.com> wrote:
> Move to using the new API devm_drm_panel_alloc() to allocate the
> panel.
>
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>

Thanks for your patch!

I have a generic comment that applies to all patches in the series.

> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -424,9 +424,11 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
>         struct otm8009a *ctx;
>         int ret;
>
> -       ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);

The old code used sizeof(*ctx) instead of an explicit type, for
increased type-safety.

> -       if (!ctx)
> -               return -ENOMEM;
> +       ctx = devm_drm_panel_alloc(dev, struct otm8009a, panel,

Can't you use __typeof(*ctx) instead of the explicit type here, too?

> +                                  &otm8009a_drm_funcs,
> +                                  DRM_MODE_CONNECTOR_DSI);
> +       if (IS_ERR(ctx))
> +               return PTR_ERR(ctx);
>
>         ctx->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
>         if (IS_ERR(ctx->reset_gpio)) {

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds