linux-kernel - Re: [PATCH] Fonts: Adding all Terminus fronts from 12 to 32 in bold, and normal versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUyX-7Qh7RcdrFPmL++OSVFuUqXks6NArsssQvHX_Epog@mail.gmail.com>
Date: Tue, 3 Jun 2025 10:53:05 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Pavel Nikulin <pavel@...-labs.com>
Cc: Jocelyn Falempe <jfalempe@...hat.com>, Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fonts: Adding all Terminus fronts from 12 to 32 in bold,
 and normal versions

        Hi Pavel,

Thanks for your patch!

On Tue, 3 Jun 2025 at 07:31, Pavel Nikulin <pavel@...-labs.com> wrote:
>
> This patch adds an option to compile-in all terminus fonts, and removed the old bold only terminus version
>
> These fonts were convereted from Terminus psf files with the help of psftools and a script.

converted

>
> This patch is non-intrusive, no options are enabled by default so most users won't notice a thing.
>
> I am placing my changes under the GPL 2.0 just as source Terminus font.
>
> Signed-off-by: Pavel Nikulin <pavel@...-labs.com>

> --- a/lib/fonts/Kconfig
> +++ b/lib/fonts/Kconfig
> @@ -112,15 +112,141 @@ config FONT_SUN12x22
>           big letters (like the letters used in the SPARC PROM). If the
>           standard font is unreadable for you, say Y, otherwise say N.
>
> -config FONT_TER16x32

So FONT_TER16x32 is now gone, thus impacting current users?

> +config FONT_TER6x12N
> +       bool "Terminus 6x12 bold font (not supported by all drivers)"
> +       depends on FRAMEBUFFER_CONSOLE || DRM_PANIC
> +       depends on !SPARC && FONTS || SPARC
> +       help
> +         Terminus Font is a clean, fixed width bitmap font, designed
> +         for long (8 and more hours per day) work with computers.
> +
> +config FONT_TER8x14B
> +       bool "Terminus 8x14 font (not supported by all drivers)"

IIRC, the "not supported by all drivers" comment is only applicable
to fonts with a width that is not a multiple of 8.

> +       depends on FRAMEBUFFER_CONSOLE || DRM_PANIC
> +       depends on !SPARC && FONTS || SPARC
> +       help
> +         Terminus Font is a clean, fixed width bitmap font, designed
> +         for long (8 and more hours per day) work with computers.
> +

> --- a/lib/fonts/Makefile
> +++ b/lib/fonts/Makefile
> @@ -14,7 +14,23 @@ font-objs-$(CONFIG_FONT_PEARL_8x8) += font_pearl_8x8.o
>  font-objs-$(CONFIG_FONT_ACORN_8x8) += font_acorn_8x8.o
>  font-objs-$(CONFIG_FONT_MINI_4x6)  += font_mini_4x6.o
>  font-objs-$(CONFIG_FONT_6x10)      += font_6x10.o
> -font-objs-$(CONFIG_FONT_TER16x32)  += font_ter16x32.o
> +font-objs-$(CONFIG_FONT_TER6x12N)  += font_ter-112n.o
> +font-objs-$(CONFIG_FONT_TER8x14B)  += font_ter-114b.o
> +font-objs-$(CONFIG_FONT_TER8x14N)  += font_ter-114n.o
> +font-objs-$(CONFIG_FONT_TER8x16B)  += font_ter-116b.o
> +font-objs-$(CONFIG_FONT_TER8x16N)  += font_ter-116n.o
> +font-objs-$(CONFIG_FONT_TER10x18B)  += font_ter-118b.o
> +font-objs-$(CONFIG_FONT_TER10x18N)  += font_ter-118n.o
> +font-objs-$(CONFIG_FONT_TER10x20B)  += font_ter-120b.o
> +font-objs-$(CONFIG_FONT_TER10x20N)  += font_ter-120n.o
> +font-objs-$(CONFIG_FONT_TER11x22B)  += font_ter-122b.o
> +font-objs-$(CONFIG_FONT_TER11x22N)  += font_ter-122n.o
> +font-objs-$(CONFIG_FONT_TER12x24B)  += font_ter-124b.o
> +font-objs-$(CONFIG_FONT_TER12x24N)  += font_ter-124n.o
> +font-objs-$(CONFIG_FONT_TER14x28B)  += font_ter-128b.o
> +font-objs-$(CONFIG_FONT_TER14x28N)  += font_ter-128n.o
> +font-objs-$(CONFIG_FONT_TER16x32B)  += font_ter-132b.o
> +font-objs-$(CONFIG_FONT_TER16x32N)  += font_ter-132n.o

Please use descriptive names for the font files, matching the
font names.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds