linux-kernel - Re: [PATCH] gve: add missing NULL check for gve_alloc_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abb065ab-1923-4154-8b79-f47a86a3d30e@oracle.com>
Date: Tue, 3 Jun 2025 14:33:59 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Bailey Forrest <bcf@...gle.com>, Eric Dumazet <edumazet@...gle.com>
Cc: Mina Almasry <almasrymina@...gle.com>, joshwash@...gle.com,
        willemb@...gle.com, pkaligineedi@...gle.com, pabeni@...hat.com,
        kuba@...nel.org, jeroendb@...gle.com, hramamurthy@...gle.com,
        andrew+netdev@...n.ch, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, darren.kenny@...cle.com
Subject: Re: [PATCH] gve: add missing NULL check for
 gve_alloc_pending_packet() in TX DQO

Hi Bailey,

On 03-06-2025 00:54, Bailey Forrest wrote:
> Hi Alok,
> 
> I think this patch isn't needed. gve_tx_add_skb_dqo() is only called
> after checking gve_maybe_stop_tx_dqo(), which checks that
> gve_alloc_pending_packet() will not return NULL.

Thank you for the clarification,

Even so, I felt it could be a bit misleading for developers and tools. 
But if you believe the patch isn't required,I completely understand.
In that case, I kindly request you to provide your NACK on the [PATCH 
net v2] mail thread for formal tracking,
so that other developers can also be aware of the reasoning and 
understand the context.

Appreciate your time and feedback!

Thanks,
Alok