linux-kernel - Re: [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests if write_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250602191216.7173b77e4f9ab5f659d1a448@linux-foundation.org>
Date: Mon, 2 Jun 2025 19:12:16 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Khaled Elnaggar <khaledelnaggarlinux@...il.com>
Cc: linux-mm@...ck.org, linux-kernel-mentees@...ts.linux.dev,
 shuah@...nel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] selftests/mm/run_vmtests.sh: skip hugevm tests
 if write_to_hugetlbfs is missing

On Tue,  3 Jun 2025 02:22:32 +0300 Khaled Elnaggar <khaledelnaggarlinux@...il.com> wrote:

> The hugevm tests 'charge_reserved_hugetlb.sh' and 'hugetlb_reparenting_test.sh'
> depend on the 'write_to_hugetlbfs' binary to simulate writes to hugetlbfs
> while checking reservations asynchronously in the background.
> 
> When this binary is missing (e.g., excluded from the build), these tests hang
> for up to 180 seconds. During this time, run_vmtests.sh is eventually killed
> due to timeout, aborting all subsequent tests.
> 
> This patch skips these tests if the binary is not found, preventing delays
> and ensuring that the test suite runs to completion.

OK, but why is write_to_hugetlbfs missing?  If we're in a situation
where we _could_ run it then we _should_ run it!  The user wants to
test stuff so we should test as much as we can.

So I'm thinking that it would be preferable to make sure the dang thing
is there?