linux-kernel - Re: [PATCH v3 2/5] PM: sleep: Suspend async parents after suspending children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hpJSVdiCN29=kbV8KfgU1y1d3hFfshtBoMpVFXf+LvBQ@mail.gmail.com>
Date: Tue, 3 Jun 2025 13:39:01 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Chris Bainbridge <chris.bainbridge@...il.com>
Cc: Mario Limonciello <superm1@...nel.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, 
	Linux PM <linux-pm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	Alan Stern <stern@...land.harvard.edu>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Johan Hovold <johan@...nel.org>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Jon Hunter <jonathanh@...dia.com>, Saravana Kannan <saravanak@...gle.com>, 
	amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH v3 2/5] PM: sleep: Suspend async parents after suspending children

On Tue, Jun 3, 2025 at 1:37 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
>
> On Tue, Jun 3, 2025 at 12:30 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
> >
> > On Tue, Jun 3, 2025 at 12:29 PM Rafael J. Wysocki <rafael@...nel.org> wrote:
> > >
> > > On Tue, Jun 3, 2025 at 12:17 PM Chris Bainbridge
> > > <chris.bainbridge@...il.com> wrote:
> > > >
> > > > On Tue, Jun 03, 2025 at 11:38:37AM +0200, Rafael J. Wysocki wrote:
> > > > >
> > > > > Chris, please check if the attached patch helps.  I'm going to post it
> > > > > as a fix anyway later today, but it would be good to verify that it is
> > > > > sufficient.
> > > >
> > > > This did not fix my test case, pstore crash log was:
> > >
> > > OK, so can you please enable PM debug messages:
> > >
> > > # echo 1 > /sys/power/pm_debug/messages
> >
> > This should be
> >
> > # echo 1 > /sys/power/pm_debug_messages
> >
> > sorry.
> >
> > > and enabled dynamic debug in drivers/base/power/main.c:
> > >
> > > # echo "file drivers/base/power/main.c +p" > /proc/dynamic_debug/control
> > >
> > > repeat the test and capture the log?
>
> Actually, no need to do this, there is an obvious bug:
> list_splice_init() should be used instead of list_splice() when the
> emptied list is going to be used again.  Ugh.
>
> Please check if the attached patch along with the previous one makes
> the issue go away entirely.

Really attached this time, sorry.

View attachment "pm-sleep-fix-error-paths.patch" of type "text/x-patch" (897 bytes)