linux-kernel - Re: [PATCH v3 2/6] Add SPAcc Skcipher support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba13c2f1-9b08-4ba7-8093-d55c16143cb2@kernel.org>
Date: Tue, 3 Jun 2025 14:07:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pavitrakumar Managutte <pavitrakumarm@...avyalabs.com>
Cc: linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, herbert@...dor.apana.org.au, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, Ruud.Derwig@...opsys.com,
 manjunath.hadli@...avyalabs.com, adityak@...avyalabs.com,
 Shweta Raikar <shwetar@...avyalabs.com>
Subject: Re: [PATCH v3 2/6] Add SPAcc Skcipher support

On 03/06/2025 14:02, Pavitrakumar Managutte wrote:

>> Please run standard kernel tools for static analysis, like coccinelle,
>> smatch and sparse, and fix reported warnings. Also please check for
>> warnings when building with W=1 for gcc and clang. Most of these
>> commands (checks or W=1 build) can build specific targets, like some
>> directory, to narrow the scope to only your code. The code here looks
>> like it needs a fix. Feel free to get in touch if the warning is not clear.
>>
Confirm that you understood this. You sent us code with obvious flaws
which would be found with tools. It's a proof you did not run these
static tools. It's not the job of community reviewers to replace the
tools. Using us instead of tools is... well, a mistake but if you think
about our limited time then kind of close to inappropriate request. So
did you understand the need of using tools BEFORE you post it?

Best regards,
Krzysztof