linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sa8775p: pmic: enable rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <geaejertcg7lfwaxgmm3dmiwvyrducjfywcis663mbwil6szff@ivpot6ekhjkw>
Date: Tue, 3 Jun 2025 16:18:50 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Tingguo Cheng <tingguo.cheng@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Rakesh Kota <quic_kotarake@...cinc.com>,
        Tingwei Zhang <quic_tingweiz@...cinc.com>, kernel@...cinc.com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8775p: pmic: enable rtc

On Thu, May 29, 2025 at 11:47:08AM +0800, Tingguo Cheng wrote:
> Add RTC node, the RTC is controlled by PMIC device via spmi bus.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> Signed-off-by: Tingguo Cheng <tingguo.cheng@....qualcomm.com>
> ---
> Changes in v2:
> - Changed the Email address from quicinc.com to oss.qualcomm.com.
> - Removed the 'allow-set-time' property because APPS is prohibited from setting the hardware RTC time.

How do we handle the offset then? Is there an nvram cell that stores
offset between RTC value and the actual time?

> - Rebased on next-20250528.
> - Link to v1: https://lore.kernel.org/r/20240902104302.3959670-1-quic_tingguoc@quicinc.com
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> index 1369c3d43f866de9d8cd5cd4985241b99c0a0454..9e0d05c1b39ce229d5d4310ea1df1bf02e689178 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> @@ -132,6 +132,13 @@ pmm8654au_0_pon_resin: resin {
>  			};
>  		};
>  
> +		pmm8654au_0_rtc: rtc@...0 {
> +			compatible = "qcom,pmk8350-rtc";
> +			reg = <0x6100>, <0x6200>;
> +			reg-names = "rtc", "alarm";
> +			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
> +		};
> +
>  		pmm8654au_0_gpios: gpio@...0 {
>  			compatible = "qcom,pmm8654au-gpio", "qcom,spmi-gpio";
>  			reg = <0x8800>;
> 
> ---
> base-commit: 4788e5176e2ae85ec6d2022a5a79aae0da083154
> change-id: 20250529-add-rtc-for-sa8775p-726de6e77500
> 
> Best regards,
> -- 
> Tingguo Cheng <tingguo.cheng@....qualcomm.com>
> 

-- 
With best wishes
Dmitry