linux-kernel - Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250603134705.wjfwrhph3z6xjgvy@bryanbrattlof.com>
Date: Tue, 3 Jun 2025 08:47:05 -0500
From: Bryan Brattlof <bb@...com>
To: Sascha Hauer <s.hauer@...gutronix.de>
CC: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/3] arm64: dts: ti: k3-am62l: add initial
 infrastructure

On June  3, 2025 thus sayeth Sascha Hauer:
> Hi Bryan,
> 
> On Wed, May 07, 2025 at 10:09:20PM -0500, Bryan Brattlof wrote:
>  +
> > +	usbss0: dwc3-usb@...0000 {
> > +		compatible = "ti,am62-usb";
> > +		reg = <0x00 0x0f900000 0x00 0x800>,
> > +		      <0x00 0x0f908000 0x00 0x400>;
> > +		clocks = <&scmi_clk 329>;
> > +		clock-names = "ref";
> > +		power-domains = <&scmi_pds 95>;
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +		ti,syscon-phy-pll-refclk = <&wkup_conf 0x45000>;
> 
> This doesn't fit together. The register referenced here...
> 
> > +		status = "disabled";
> > +
> > +		usb0: usb@...00000 {
> > +			compatible = "snps,dwc3";
> > +			reg = <0x00 0x31000000 0x00 0x50000>;
> > +			interrupts = <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>, /* irq.0 */
> > +				     <GIC_SPI 215 IRQ_TYPE_LEVEL_HIGH>; /* irq.0 */
> > +			interrupt-names = "host", "peripheral";
> > +			maximum-speed = "high-speed";
> > +			dr_mode = "otg";
> > +			snps,usb2-gadget-lpm-disable;
> > +			snps,usb2-lpm-disable;
> > +			bootph-all;
> > +		};
> > +	};
> > +
> > +	wkup_conf: syscon@...00000 {
> > +		compatible = "syscon", "simple-mfd";
> > +		reg = <0x00 0x43000000 0x00 0x20000>;
> 
> ...is outside the register range specified here. Consequently the DWC3
> driver doesn't probe. Increasing the register range here fixes this.
> 

Oops yeah I really messed up on this. :/

Thanks for double checking all of this
~Bryan