linux-kernel - Re: [PATCH v1] iommu/vt-d: Remove dead code in intel_iommu_domain_alloc_paging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250603150656.GA407166@ziepe.ca>
Date: Tue, 3 Jun 2025 12:06:56 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Wei Wang <wei.w.wang@...el.com>
Cc: baolu.lu@...ux.intel.com, kevin.tian@...el.com, yi.l.liu@...el.com,
	dwmw2@...radead.org, jroedel@...e.de, linux-kernel@...r.kernel.org,
	iommu@...ts.linux.dev
Subject: Re: [PATCH v1] iommu/vt-d: Remove dead code in
 intel_iommu_domain_alloc_paging_flags()

On Fri, May 30, 2025 at 05:13:25PM +0800, Wei Wang wrote:
> When dirty_tracking is enabled, first_stage is set to false to use the
> second stage translation table. dmar_domain->use_first_level, which is
> assigned from first_page, is guaranteed to be false when the execution
> reaches the location of the code to be removed by this patch. So the
> handling for dmar_domain->use_first_level being true there will never
> be executed.
> 
> Signed-off-by: Wei Wang <wei.w.wang@...el.com>
> ---
>  drivers/iommu/intel/iommu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

I noticed this too

Jason