linux-kernel - Re: [PATCH 1/3] PCI: Add PCIE_SPEED2LNKCTL2_TLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7191e865-4aa1-4de3-aa50-f32ea2786b5f@163.com>
Date: Tue, 3 Jun 2025 23:31:31 +0800
From: Hans Zhang <18255117159@....com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 krzk+dt@...nel.org, manivannan.sadhasivam@...aro.org, jingoohan1@...il.com,
 robh@...nel.org, linux-pci@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] PCI: Add PCIE_SPEED2LNKCTL2_TLS_ENC conversion macro



On 2025/6/3 17:08, Ilpo Järvinen wrote:
> On Tue, 20 May 2025, Hans Zhang wrote:
> 
>> Introduce PCIE_SPEED2LNKCTL2_TLS_ENC macro to standardize the conversion
> 
> Use () parenthesis like you'd use them in C so functions and macros in
> changelog should have them appended.
> 

Dear Ilpo,

Thank you very much for your reply and reminder. Will change.

>> between PCIe speed enumerations and LNKCTL2_TLS register values. This
>> centralizes speed-to-register mapping logic, eliminating duplicated
>> conversion code across multiple drivers.
>>
>> Signed-off-by: Hans Zhang <18255117159@....com>
>> ---
>>   drivers/pci/pci.h | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
>> index f92928dadc6a..b7e2d08825c6 100644
>> --- a/drivers/pci/pci.h
>> +++ b/drivers/pci/pci.h
>> @@ -415,6 +415,15 @@ void pci_bus_put(struct pci_bus *bus);
>>   	 (lnkctl2) == PCI_EXP_LNKCTL2_TLS_2_5GT ? PCIE_SPEED_2_5GT : \
>>   	 PCI_SPEED_UNKNOWN)
>>   
>> +#define PCIE_SPEED2LNKCTL2_TLS_ENC(speed) \
> 
> I'm not a big fan of including that _ENC there, it just makes the long
> name even longer and doesn't really provide added value, IMO.
> 

Will delete _ENC.

Best regards,
Hans

> Other than those, this change logs fine.
> 
>> +	((speed) == PCIE_SPEED_2_5GT ? PCI_EXP_LNKCTL2_TLS_2_5GT : \
>> +	 (speed) == PCIE_SPEED_5_0GT ? PCI_EXP_LNKCTL2_TLS_5_0GT : \
>> +	 (speed) == PCIE_SPEED_8_0GT ? PCI_EXP_LNKCTL2_TLS_8_0GT : \
>> +	 (speed) == PCIE_SPEED_16_0GT ? PCI_EXP_LNKCTL2_TLS_16_0GT : \
>> +	 (speed) == PCIE_SPEED_32_0GT ? PCI_EXP_LNKCTL2_TLS_32_0GT : \
>> +	 (speed) == PCIE_SPEED_64_0GT ? PCI_EXP_LNKCTL2_TLS_64_0GT : \
>> +	 0)
>> +
>>   /* PCIe speed to Mb/s reduced by encoding overhead */
>>   #define PCIE_SPEED2MBS_ENC(speed) \
>>   	((speed) == PCIE_SPEED_64_0GT ? 64000*1/1 : \
>>
>