linux-kernel - Re: [PATCH 5/5] dt-bindings: mailbox: Drop consumers example DTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250603154904.oa5lx5loywmzoqhr@varmint>
Date: Tue, 3 Jun 2025 10:49:04 -0500
From: Nishanth Menon <nm@...com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
CC: Jassi Brar <jassisinghbrar@...il.com>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Kevin Hilman
	<khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin
 Blumenstingl <martin.blumenstingl@...glemail.com>,
        Chen-Yu Tsai
	<wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland
	<samuel@...lland.org>, Sven Peter <sven@...npeter.dev>,
        Janne Grunau
	<j@...nau.net>, Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Neal Gompa
	<neal@...pa.dev>, Hector Martin <marcan@...can.st>,
        Thierry Reding
	<thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>, Suman
 Anna <s-anna@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
        <asahi@...ts.linux.dev>, <linux-tegra@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH 5/5] dt-bindings: mailbox: Drop consumers example DTS

On 13:57-20250603, Krzysztof Kozlowski wrote:
> Providers DTS examples should not contain consumer nodes, because they
> are completely redundant, obvious (defined in common schema) and add
> unnecessary bloat.  Drop consumer examples and unneeded node labels.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

[...]

> diff --git a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
> index 1a2001e58880d2fc26954b26cff8ed53e7667f33..8504ceb64806bc7e25468597acdff99624571e9f 100644
> --- a/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
> @@ -242,7 +242,7 @@ examples:
>    - |
>      /* OMAP4 */
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
> -    mailbox: mailbox@...f4000 {
> +    mailbox@...f4000 {
>          compatible = "ti,omap4-mailbox";
>          reg = <0x4a0f4000 0x200>;
>          interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> @@ -260,13 +260,9 @@ examples:
>          };
>      };
>  
> -    dsp {
> -        mboxes = <&mailbox &mbox_dsp>;
> -    };
> -
>    - |
>      /* AM33xx */
> -    mailbox1: mailbox@...c8000 {
> +    mailbox@...c8000 {
>          compatible = "ti,omap4-mailbox";
>          reg = <0x480c8000 0x200>;
>          interrupts = <77>;
> @@ -283,7 +279,7 @@ examples:
>  
>    - |
>      /* AM65x */
> -    mailbox0_cluster0: mailbox@...80000 {
> +    mailbox@...80000 {
>          compatible = "ti,am654-mailbox";
>          reg = <0x31f80000 0x200>;
>          #mbox-cells = <1>;
> 

Reviewed-by: Nishanth Menon <nm@...com>

> -- 
> 2.45.2
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D