linux-kernel - Re: [PATCH v1 3/3] PM: sleep: Add locking to dpm_async_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hXnLY8p8ZJKu57PwM8dsAYGmjhQc9tz5UbmL8worveyw@mail.gmail.com>
Date: Tue, 3 Jun 2025 18:31:52 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: "Limonciello, Mario" <Mario.Limonciello@....com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>, Linux PM <linux-pm@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, 
	Chris Bainbridge <chris.bainbridge@...il.com>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Saravana Kannan <saravanak@...gle.com>, Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v1 3/3] PM: sleep: Add locking to dpm_async_resume_children()

On Tue, Jun 3, 2025 at 6:27 PM Limonciello, Mario
<Mario.Limonciello@....com> wrote:
>
> On 6/3/25 11:21 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >
> > Commit 0cbef962ce1f ("PM: sleep: Resume children after resuming the
> > parent") introduced a subtle concurrency issue that may lead to a kernel
> > crash if system suspend is aborted and may also slow down asynchronous
> > device resume otherwise.
> >
> > Namely, the initial list walks in dpm_noirq_resume_devices(),
> > dpm_resume_early(), and dpm_resume() call dpm_clear_async_state() for
> > every device and attepmt to asynchronously resume it if it has no
>
> s/attepmt/attempts/

It is plural, but yes, s/attepmt/attempt/

Will fix when applying, thanks!