linux-kernel - Re: [PATCH v6 3/9] x86/nmi: Extend the registration interface to include the NMI-source vector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e6d865c-597f-4281-a07b-94aeffe938d6@intel.com>
Date: Tue, 3 Jun 2025 10:07:47 -0700
From: Dave Hansen <dave.hansen@...el.com>
To: Sohil Mehta <sohil.mehta@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Xin Li <xin@...or.com>, "H . Peter Anvin" <hpa@...or.com>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>,
 Peter Zijlstra <peterz@...radead.org>,
 Sean Christopherson <seanjc@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 Kan Liang <kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>,
 Zhang Rui <rui.zhang@...el.com>, Steven Rostedt <rostedt@...dmis.org>,
 Andrew Cooper <andrew.cooper3@...rix.com>,
 "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
 Jacob Pan <jacob.pan@...ux.microsoft.com>, Andi Kleen <ak@...ux.intel.com>,
 Kai Huang <kai.huang@...el.com>, Sandipan Das <sandipan.das@....com>,
 linux-perf-users@...r.kernel.org, linux-edac@...r.kernel.org,
 kvm@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/9] x86/nmi: Extend the registration interface to
 include the NMI-source vector

On 5/13/25 13:37, Sohil Mehta wrote:
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -242,13 +242,13 @@ static int hpwdt_init_nmi_decoding(struct pci_dev *dev)
>  	/*
>  	 * Only one function can register for NMI_UNKNOWN
>  	 */
> -	retval = register_nmi_handler(NMI_UNKNOWN, hpwdt_pretimeout, 0, "hpwdt");
> +	retval = register_nmi_handler(NMI_UNKNOWN, hpwdt_pretimeout, 0, "hpwdt", 0);
>  	if (retval)
>  		goto error;
> -	retval = register_nmi_handler(NMI_SERR, hpwdt_pretimeout, 0, "hpwdt");
> +	retval = register_nmi_handler(NMI_SERR, hpwdt_pretimeout, 0, "hpwdt", 0);
>  	if (retval)
>  		goto error1;
> -	retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt");
> +	retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout, 0, "hpwdt", 0);
>  	if (retval)

Could we get rid of all these random 0's, please? (or at least try to
keep them from proliferating).

Either do a:

	register_nmi_handler_source()

that takes a source and leave

	register_nmi_handler()

in place and not take a source. Or, do this:

	retval = register_nmi_handler(NMI_IO_CHECK, hpwdt_pretimeout,
				      0, "hpwdt", NMI_NO_SOURCE);

where the 0 is at least given a symbolic name.