linux-kernel - Re: [PATCH v5 6/8] serial: qcom-geni: move clock-rate logic to separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f18716f-cba2-4615-950a-63b6b73e23e9@quicinc.com>
Date: Wed, 4 Jun 2025 22:41:30 +0530
From: Praveen Talari <quic_ptalari@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <devicetree@...r.kernel.org>
CC: <psodagud@...cinc.com>, <djaggi@...cinc.com>, <quic_msavaliy@...cinc.com>,
        <quic_vtanuku@...cinc.com>, <quic_arandive@...cinc.com>,
        <quic_mnaresh@...cinc.com>, <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v5 6/8] serial: qcom-geni: move clock-rate logic to
 separate function

Hi Bryan,

On 6/3/2025 8:11 PM, Bryan O'Donoghue wrote:
> On 06/05/2025 19:02, Praveen Talari wrote:
>> -            "Couldn't find suitable clock rate for %u\n",
>> +            "Couldn't find suitable clock rate for %lu\n",
>>               baud * sampling_rate);
>> -        return;
>> +        return -EINVAL;
>>       }
>>
>> -    dev_dbg(port->se.dev, "desired_rate = %u, clk_rate = %lu, clk_div 
>> = %u\n",
>> -            baud * sampling_rate, clk_rate, clk_div);
>> +    dev_dbg(port->se.dev, "desired_rate = %lu, clk_rate = %lu, 
>> clk_div = %u\n",
>> +        baud * sampling_rate, clk_rate, clk_div);
> 
> Separate this stuff out.
> 
> Your code should match the commit log. If you want to convert %u to %lu 
> make a patch to do that, even if it seems trivial, it is better to make 
> granular submissions.

It comes under newly added API. Do we still need to make separate patch?

Thanks,
Praveen Talari
> 
> ---
> bod