linux-kernel - Re: [PATCH v5 03/29] x86/resctrl: Remove 'rdt_mon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fde3cab1-032f-4c6d-aaa2-e684ede63194@intel.com>
Date: Tue, 3 Jun 2025 20:27:23 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Anil Keshavamurthy <anil.s.keshavamurthy@...el.com>,
	Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v5 03/29] x86/resctrl: Remove 'rdt_mon_features' global
 variable

Hi Tony,

On 5/21/25 3:50 PM, Tony Luck wrote:
> This variable was used as a bitmask of enabled monitor events. But
> that function is now provided by the filesystem mon_event_all[] array.
> 
> Remove the remaining uses of this variable.

I do not see any reason why this changelog needs to be so obfuscated. Why go
through effort of referring to rdt_mon_features as "this variable" throughout
changelog when it could just be called by name? Same with "that function".
Compare with:

	rdt_mon_features is used as a bitmask of enabled monitor events. A monitor
	event's status is now maintained in mon_evt::enabled with all monitor
	events' mon_evt structures found in the filesystem's mon_event_all[] array.

	Remove the remaining uses of rdt_mon_features.

Patch looks good.

Reinette