[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<TYZPR06MB656889259D6BE8846E2A1F65F16CA@TYZPR06MB6568.apcprd06.prod.outlook.com>
Date: Wed, 4 Jun 2025 00:46:11 +0000
From: Jammy Huang <jammy_huang@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "jassisinghbrar@...il.com"
<jassisinghbrar@...il.com>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, "joel@....id.au" <joel@....id.au>,
"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series
SoC
> On 03/06/2025 11:22, Krzysztof Kozlowski wrote:
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - interrupts
> >> + - "#mbox-cells"
> >> +
> >> +additionalProperties: false
> >> +
> >> +examples:
> >> + - |
> >> + #include <dt-bindings/interrupt-controller/irq.h>
> >> +
> >> + mbox@...1c200 {
> >
> > mailbox@
> >
> > With these fixed:
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Huh, not tested.... so obviously un-reviewed.
>
> Test your code BEFORE you send, not via community services.
>
> Best regards,
> Krzysztof
Thanks for the review.
I will update accordingly and make sure test passed in later patch.
Best Regards,
Jammy Huang
Powered by blists - more mailing lists