linux-kernel - Re: [PATCH 5/6] dt-bindings: power: supply: summit,smb347: Add missing power-supply ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ca76e4a-fe95-41b2-9f72-6c1a6219cbff@ixit.cz>
Date: Wed, 4 Jun 2025 10:39:04 +0200
From: David Heidelberg <david@...t.cz>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Sebastian Reichel <sre@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andrew Davis <afd@...com>,
 Casey Connolly <casey.connolly@...aro.org>,
 Jakob Hauser <jahau@...ketmail.com>, Dmitry Osipenko <digetx@...il.com>,
 Tobias Schrammm <t.schramm@...jaro.org>,
 Linus Walleij <linus.walleij@...aro.org>, Chen-Yu Tsai <wens@...e.org>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: power: supply: summit,smb347: Add
 missing power-supply ref

Thank you,

Reviewed-by: David Heidelberg <david@...t.cz>


On 04/06/2025 10:18, Krzysztof Kozlowski wrote:
> Reference the common power supply schema to bring the definition of
> monitored-battery property.  Drop also the obvious description because
> it is duplicating what is in power-supply.yaml.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   .../devicetree/bindings/power/supply/summit,smb347-charger.yaml      | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 2d552becbfe6cb08c72f2a5584bdddc67443a2e4..65ed92bb05f30f91e24978d3261c7f29e4233e2b 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -23,9 +23,7 @@ properties:
>     interrupts:
>       maxItems: 1
>   
> -  monitored-battery:
> -    description: phandle to the battery node
> -    $ref: /schemas/types.yaml#/definitions/phandle
> +  monitored-battery: true
>   
>     summit,enable-usb-charging:
>       type: boolean
> @@ -94,6 +92,7 @@ properties:
>       unevaluatedProperties: false
>   
>   allOf:
> +  - $ref: power-supply.yaml#
>     - if:
>         properties:
>           compatible:
>