linux-kernel - Re: [PATCH v2 1/2] dt-bindings: reset: eswin: Documentation for eic7700 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df534020-f34c-4d23-85c4-eb9c241e5c7b@kernel.org>
Date: Wed, 4 Jun 2025 11:03:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: dongxuyang@...incomputing.com, p.zabel@...gutronix.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: ningyu@...incomputing.com, linmin@...incomputing.com,
 huangyifeng@...incomputing.com
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: eswin: Documentation for
 eic7700 SoC

On 04/06/2025 10:52, dongxuyang@...incomputing.com wrote:
> +
> +properties:
> +  compatible:
> +    items:
> +      - const: eswin,eic7700-reset
> +      - const: syscon

Hm? Did you just add it for the driver? If so, then no, drop. Use
standard MMIO regmap (if you want regmap).

> +      - const: simple-mfd

Why did this appear? Changelog is silent on this and it makes no sense
here. No children.

> +
> +  reg:
> +    maxItems: 1
> +
> +  '#reset-cells':
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - '#reset-cells'
> +
Best regards,
Krzysztof