linux-kernel - Re: [PATCH] EDAC/synopsys: Clear the ecc counters at init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250604093735.GAaEAT39KGW1KJDrjD@fat_crate.local>
Date: Wed, 4 Jun 2025 11:37:35 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"git (AMD-Xilinx)" <git@....com>,
	"Simek, Michal" <michal.simek@....com>,
	Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>
Subject: Re: [PATCH] EDAC/synopsys: Clear the ecc counters at init

On Wed, Jun 04, 2025 at 05:58:22AM +0000, Datta, Shubhrajyoti wrote:
> zynqmp_get_ecc_state is getting called from probe/init.
> I will update the commit message to reflect the same.

No need.

Next question: There's zynq_get_ecc_state() which is almost the same. Does
that need clearing too?

If so, the right thing to do is to unify both functions and get rid of the
silly function pointers calling them but simply do ECC state reading once in
mc_probe() and be done with it.

The duplication here is very much unnecessary.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette