linux-kernel - [PATCH AUTOSEL 6.14 014/108] Bluetooth: btmtksdio: Fix wakeup source leaks on device unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250604005531.4178547-14-sashal@kernel.org>
Date: Tue,  3 Jun 2025 20:53:57 -0400
From: Sasha Levin <sashal@...nel.org>
To: patches@...ts.linux.dev,
	stable@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	Luiz Augusto von Dentz <luiz.von.dentz@...el.com>,
	Sasha Levin <sashal@...nel.org>,
	marcel@...tmann.org,
	luiz.dentz@...il.com,
	matthias.bgg@...il.com,
	angelogioacchino.delregno@...labora.com,
	linux-bluetooth@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: [PATCH AUTOSEL 6.14 014/108] Bluetooth: btmtksdio: Fix wakeup source leaks on device unbind

From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

[ Upstream commit ee3e4209e66d44180a41d5ca7271361a2a28fccf ]

Device can be unbound or probe can fail, so driver must also release
memory for the wakeup source.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@...el.com>
Signed-off-by: Sasha Levin <sashal@...nel.org>
---

**YES** This commit should be backported to stable kernel trees. Here's
my extensive analysis: ## Detailed Analysis ### 1. Nature of the Bug
This is a **resource leak fix** that addresses a memory leak in wakeup
source management. The change from `device_init_wakeup(bdev->dev, true)`
to `devm_device_init_wakeup(bdev->dev)` is critical because: - **Manual
management risk**: The original code manually enables wakeup capability
but has no corresponding cleanup in the remove path - **Automatic
cleanup**: The new `devm_device_init_wakeup()` uses the device resource
management framework to automatically clean up wakeup sources when the
device is unbound ### 2. Impact and Severity **Memory leak occurs
when:** - Device is unbound/removed - Driver probe fails after wakeup
initialization - System module unloading **What gets leaked:** - `struct
wakeup_source` structures (~200 bytes each) - Associated name strings
and metadata - Debugfs entries - IDA allocations for unique IDs ### 3.
Pattern Recognition from Similar Commits Looking at the historical
similar commits provided, I can see this is part of a **systematic
kernel-wide fix campaign**: - **Commits #4 and #5** (gpio-zynq and gpio-
mpc8xxx) show identical patterns with "Backport Status: YES" - **Commits
#1, #2, #3** are feature additions/improvements with "Backport Status:
NO" The gpio commits demonstrate this exact same fix pattern being
deemed appropriate for stable backporting. ### 4. Code Analysis The fix
is **minimal and contained**: ```c - err = device_init_wakeup(bdev->dev,
true); + err = devm_device_init_wakeup(bdev->dev); ``` **Risk
assessment:** - **Very low regression risk**:
`devm_device_init_wakeup()` is a simple wrapper that adds automatic
cleanup - **No functional changes**: Same wakeup behavior, just proper
resource management - **Well-tested pattern**: Same fix applied across
multiple kernel subsystems ### 5. Stable Tree Criteria Compliance ✅
**Fixes important bug**: Resource leaks can lead to memory exhaustion ✅
**Small and contained**: Single line change ✅ **Clear side effects**:
None beyond fixing the leak ✅ **No architectural changes**: Pure
resource management improvement ✅ **Minimal regression risk**: Uses
established devres patterns ✅ **Author expertise**: Krzysztof Kozlowski
is a well-known kernel maintainer ### 6. Driver Importance The btmtksdio
driver supports MediaTek Bluetooth SDIO devices, which are widely used
in: - Android smartphones and tablets - IoT devices - Embedded systems -
Consumer electronics Device unbinding is common during: - System
suspend/resume cycles - Module loading/unloading - Device hotplug
scenarios - Driver updates ### 7. Comparison with Reference Commits This
commit closely matches the **"YES"** examples (commits #4 and #5): -
Same author (Krzysztof Kozlowski) - Identical fix pattern
(`device_init_wakeup` → `devm_device_init_wakeup`) - Same commit message
structure - Same Cc: stable@...r.kernel.org tag - Same resource leak
issue being addressed **Conclusion**: This is a straightforward resource
leak fix that follows established patterns for stable tree backporting.
The risk is minimal while the benefit is clear - preventing memory leaks
that could lead to system instability over time.

 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index 1d26207b2ba70..c16a3518b8ffa 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -1414,7 +1414,7 @@ static int btmtksdio_probe(struct sdio_func *func,
 	 */
 	pm_runtime_put_noidle(bdev->dev);

-	err = device_init_wakeup(bdev->dev, true);
+	err = devm_device_init_wakeup(bdev->dev);
 	if (err)
 		bt_dev_err(hdev, "failed to initialize device wakeup");

-- 
2.39.5