linux-kernel - Re: [PATCH v4 1/3] mm,slub: Do not special case N_NORMAL nodes for slab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f69c29a4-ee31-49b3-9430-62c1f752e72b@huawei.com>
Date: Wed, 4 Jun 2025 20:16:59 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Oscar Salvador <osalvador@...e.de>, Andrew Morton
	<akpm@...ux-foundation.org>
CC: David Hildenbrand <david@...hat.com>, Vlastimil Babka <vbabka@...e.cz>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, Harry Yoo
	<harry.yoo@...cle.com>, Rakie Kim <rakie.kim@...com>, Hyeonggon Yoo
	<42.hyeyoo@...il.com>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/3] mm,slub: Do not special case N_NORMAL nodes for
 slab_nodes

On 2025/6/3 19:08, Oscar Salvador wrote:
> Currently, slab_mem_going_going_callback() checks whether the node has

slab_mem_going_going_callback() might be a typo here.
I suppose slab_mem_going_online_callback() might be the correct one here.

> N_NORMAL memory in order to be set in slab_nodes.
> While it is true that gettind rid of that enforcing would mean
> ending up with movables nodes in slab_nodes, the memory waste that comes
> with that is negligible.
> 
> So stop checking for status_change_nid_normal and just use status_change_nid
> instead which works for both types of memory.
> 
> Also, once we allocate the kmem_cache_node cache  for the node in
                                                  ^^
seems like a minor nit, an extral space for the above.