linux-kernel - Re: [PATCH v2 2/2] kernel/rcu/tree_stall: add /sys/kernel/rcu_stall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250603171628.695542215c05af8727dc57a0@linux-foundation.org>
Date: Tue, 3 Jun 2025 17:16:28 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Sourabh Jain <sourabhjain@...ux.ibm.com>
Cc: Max Kellermann <max.kellermann@...os.com>, song@...nel.org,
 joel.granados@...nel.org, dianders@...omium.org, cminyard@...sta.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] kernel/rcu/tree_stall: add
 /sys/kernel/rcu_stall_count

On Tue, 3 Jun 2025 22:09:30 +0530 Sourabh Jain <sourabhjain@...ux.ibm.com> wrote:

> Hello Andrew,
> 
> > +#endif
> > +
> >   		rcu_stall_notifier_call_chain(RCU_STALL_NOTIFY_NORM, (void *)j - gps);
> >   		if (READ_ONCE(csd_lock_suppress_rcu_stall) && csd_lock_is_stuck()) {
> >   			pr_err("INFO: %s detected stall, but suppressed full report due to a stuck CSD-lock.\n", rcu_state.name);
> 
> It seems like this patch was not applied properly to the upstream tree.
> 
> Out of the three hunks in this patch, only the first one is applied; the 
> second
> and third hunks are missing.
> 
> commit 2536c5c7d6ae5e1d844aa21f28b326b5e7f815ef
> Author: Max Kellermann <max.kellermann@...os.com>
> Date:   Sun May 4 20:08:31 2025 +0200
> 
>      kernel/rcu/tree_stall: add /sys/kernel/rcu_stall_count
> 
>      Expose a simple counter to userspace for monitoring tools.

OK.  iirc there was quite a lot of churn and conflicts here :)

Please send a fixup against latest -linus?