linux-kernel - Re: [PATCH] mm: rename CONFIG_PAGE_BLOCK_ORDER to CONFIG_PAGE_BLOCK_ORDER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CF888D46-CEEC-4008-A908-B7529CF237AA@nvidia.com>
Date: Wed, 04 Jun 2025 09:36:59 -0400
From: Zi Yan <ziy@...dia.com>
To: David Hildenbrand <david@...hat.com>
Cc: Anshuman Khandual <anshuman.khandual@....com>, Liam.Howlett@...cle.com,
 akpm@...ux-foundation.org, isaacmanjarres@...gle.com, jyescas@...gle.com,
 kaleshsingh@...gle.com, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 lorenzo.stoakes@...cle.com, masahiroy@...nel.org, mhocko@...e.com,
 minchan@...nel.org, rppt@...nel.org, surenb@...gle.com, tjmercier@...gle.com,
 vbabka@...e.cz
Subject: Re: [PATCH] mm: rename CONFIG_PAGE_BLOCK_ORDER to
 CONFIG_PAGE_BLOCK_ORDER_CEIL.

On 4 Jun 2025, at 9:31, David Hildenbrand wrote:

> On 04.06.25 15:26, Zi Yan wrote:
>> On 4 Jun 2025, at 0:36, Anshuman Khandual wrote:
>>
>>> On 6/3/25 21:18, Zi Yan wrote:
>>>> The config is in fact an additional upper limit of pageblock_order, so
>>>> rename it to avoid confusion.
>>>
>>> Agreed. This new config has been similar to existing 'pageblock_order'
>>> that might cause confusion. Hence renaming makes sense. But instead of
>>> PAGE_BLOCK_ORDER_CEIL should it be rather PAGE_BLOCK_ORDER_MAX ?
>>
>> Or PAGE_BLOCK_MAX_ORDER?
>
> Would also work for me.
>
>>
>>>
>>>>
>>>> Fixes: e13e7922d034 ("mm: add CONFIG_PAGE_BLOCK_ORDER to select page block order")
>>>
>>> Does it really need a "Fixes: " tag given there is no problem to fix ?
>>
>> I have no strong opinion on this one.
>
> Probably we want this to go into this release. No need for a Fixes: I assume.

OK. I will send v2 later today, so that Anshuman has a chance to reply to my
new name.

V2 will has following changes:
1. the new name: PAGE_BLOCK_MAX_ORDER,
2. add the missing PAGE_BLOCK_ORDER rename in mm/mm_init.c[1]
3. drop the Fixes.

[1] https://lore.kernel.org/linux-mm/202506042058.XgvABCE0-lkp@intel.com/

--
Best Regards,
Yan, Zi