linux-kernel - Re: [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dcaea307-bbd8-4b6a-ad6c-04f6a2d8e473@kernel.org>
Date: Wed, 4 Jun 2025 16:03:02 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Ioan-daniel, Pop" <Pop.Ioan-daniel@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 "Hennerich, Michael" <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 "Sa, Nuno" <Nuno.Sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "Cuciurean, Sergiu" <Sergiu.Cuciurean@...log.com>,
 "Bogdan, Dragos" <Dragos.Bogdan@...log.com>,
 "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>,
 Olivier Moysan <olivier.moysan@...s.st.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Matti Vaittinen <mazziesaccount@...il.com>,
 Tobias Sperling <tobias.sperling@...ting.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>,
 "Schmitt, Marcelo" <Marcelo.Schmitt@...log.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Trevor Gamblin <tgamblin@...libre.com>,
 "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 4/5] dt-bindings: iio: adc: add ad7405

On 04/06/2025 15:05, Ioan-daniel, Pop wrote:
>>
>> On 02/06/2025 15:43, Pop Ioan Daniel wrote:
>>> Add devicetree bindings for ad7405/adum770x family.
>>>
>>> Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@...log.com>
>>> ---
>>> changes in v5:
>>>  - create an example based on adi,ad7625.yaml that is very similar to this
>> part
>>>  - do not add Reviewed-by tag due to the change that I've made.
>>
>> Which change? I see ZERO differences against version which was reviewed.
> 
> Hi! The difference is in the io-backends assignment:

Change in the binding. You just pasted example. What change did you make
to invalidate review?

> examples:
> +  - |
> +    adc {
> +        compatible = "adi,ad7405";
> +        clocks = <&axi_clk_gen 0>;
> +        vdd1-supply = <&vdd1>;
> +        vdd2-supply = <&vdd2>;
> +        io-backends = <&axi_adc>;
> +    };
> +...


Best regards,
Krzysztof