linux-kernel - Re: [PATCH v3 5/6] power: supply: pf1550: add battery charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aEBTZD1WmS14qoNc@fedora>
Date: Wed, 4 Jun 2025 10:08:36 -0400
From: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-input@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh@...nel.org>, Sebastian Reichel <sre@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Abel Vesa <abelvesa@...nel.org>, Abel Vesa <abelvesa@...ux.com>,
	Enric Balletbo i Serra <eballetbo@...il.com>,
	Robin Gong <b38343@...escale.com>, Robin Gong <yibin.gong@....com>
Subject: Re: [PATCH v3 5/6] power: supply: pf1550: add battery charger support

On Mon, Jun 02, 2025 at 08:44:04PM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/power/supply/pf1550-charger.c
> > @@ -0,0 +1,639 @@
> …
> > +static void pf1550_charger_irq_work(struct work_struct *work)
> > +{
> …
> > +	mutex_lock(&chg->mutex);
> > +
> > +	for (i = 0; i < PF1550_CHARGER_IRQ_NR; i++) {
> …
> > +	mutex_unlock(&chg->mutex);
> > +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(mutex)(&chg->mutex);”?
> https://elixir.bootlin.com/linux/v6.15/source/include/linux/mutex.h#L201
>
I think it can be applied to v4 of this patch. I'll try it out and tag you on
the next version.

Thanks,
Sam