linux-kernel - Re: [PATCH v5 5/8] serial: qcom-geni: move resource control logic to separate functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0daf396a-29af-458b-a7ba-3b711b22cde9@quicinc.com>
Date: Wed, 4 Jun 2025 19:39:45 +0530
From: Praveen Talari <quic_ptalari@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <devicetree@...r.kernel.org>
CC: <psodagud@...cinc.com>, <djaggi@...cinc.com>, <quic_msavaliy@...cinc.com>,
        <quic_vtanuku@...cinc.com>, <quic_arandive@...cinc.com>,
        <quic_mnaresh@...cinc.com>, <quic_shazhuss@...cinc.com>
Subject: Re: [PATCH v5 5/8] serial: qcom-geni: move resource control logic to
 separate functions

Hi Bryan

On 6/3/2025 8:16 PM, Bryan O'Donoghue wrote:
> On 03/06/2025 15:29, Bryan O'Donoghue wrote:
>> On 03/06/2025 15:28, Bryan O'Donoghue wrote:
>>>> 2.17.1
>>>>
>>>>
>>> Assuming you address my points.
>>
>> [sic]
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>>
> 
> Oh please fix this in the next version
can i fix this in separate patch since i haven't touch these two lines
or
fix within same patch?

Thanks,
Praveen Talari
> 
> checkpatch.pl --strict mypatch.patch
> 
> CHECK: Alignment should match open parenthesis
> #92: FILE: drivers/tty/serial/qcom_geni_serial.c:1675:
> +    else if (new_state == UART_PM_STATE_OFF &&
> +            old_state == UART_PM_STATE_ON)
> 
> total: 0 errors, 0 warnings, 1 checks, 71 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>        mechanically convert to the typical style using --fix or 
> --fix-inplace.
> 
> 0005-serial-qcom-geni-move-resource-control-logic-to-sepa.patch has 
> style problems, please review.
> 
> ---
> bod