linux-kernel - Re: [PATCH v1] speakup: Replace u_short with u16 for spk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEBe_wji03rJPBwj@begin>
Date: Wed, 4 Jun 2025 16:58:07 +0200
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: Jagadeesh Yalapalli <jagadeesharm14@...il.com>
Cc: William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...sers.ca>, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>, speakup@...ux-speakup.org,
	linux-kernel@...r.kernel.org,
	Jagadeesh Yalapalli <jagadeesh.yalapalli@...fochips.com>
Subject: Re: [PATCH v1] speakup: Replace u_short with u16 for spk_chartab

Hello,

Jagadeesh Yalapalli, le mer. 04 juin 2025 13:58:36 +0000, a ecrit:
> From: Jagadeesh Yalapalli <jagadeesh.yalapalli@...fochips.com>
> 
> The spk_chartab array was previously declared as `u_short`,
> which is a non-standard type and may vary in size across platforms.
> Replace it with `u16` to ensure consistent 16-bit width and improve
> code portability and readability.

There is much more to it than just this line: there is also the
declaration in speakup.h, and the comment above, and all related
variables such as default_chartab, the variables in functions such as
charclass, mask, char_type, ch_type, ...

Samuel

> Signed-off-by: Jagadeesh Yalapalli <jagadeesh.yalapalli@...fochips.com>
> ---
>  drivers/accessibility/speakup/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
> index e68cf1d83787..34c7cb6a9b43 100644
> --- a/drivers/accessibility/speakup/main.c
> +++ b/drivers/accessibility/speakup/main.c
> @@ -187,7 +187,7 @@ char *spk_default_chars[256] = {
>   * initialized to default_chartab and user selectable via
>   * /sys/module/speakup/parameters/chartab
>   */
> -u_short spk_chartab[256];
> +u16 spk_chartab[256];
>  
>  static u_short default_chartab[256] = {
>  	B_CTL, B_CTL, B_CTL, B_CTL, B_CTL, B_CTL, B_CTL, B_CTL,	/* 0-7 */
> -- 
> 2.43.0