linux-kernel - Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown NMI console message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa948d41-3f95-4385-86c1-5c115561b939@intel.com>
Date: Tue, 3 Jun 2025 18:55:56 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Xin Li <xin@...or.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>
CC: "H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>, Sean Christopherson
	<seanjc@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, Zhang Rui
	<rui.zhang@...el.com>, Steven Rostedt <rostedt@...dmis.org>, Andrew Cooper
	<andrew.cooper3@...rix.com>, "Kirill A . Shutemov"
	<kirill.shutemov@...ux.intel.com>, Jacob Pan <jacob.pan@...ux.microsoft.com>,
	Andi Kleen <ak@...ux.intel.com>, Kai Huang <kai.huang@...el.com>, "Sandipan
 Das" <sandipan.das@....com>, <linux-perf-users@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 9/9] x86/nmi: Print source information with the unknown
 NMI console message

On 6/3/2025 9:55 AM, Xin Li wrote:
> On 5/13/2025 1:38 PM, Sohil Mehta wrote:
>> +	if (cpu_feature_enabled(X86_FEATURE_NMI_SOURCE))
>> +		pr_emerg_ratelimited("NMI-source bitmap is 0x%lx\n", fred_event_data(regs));
> 
> "0x%04lx"?

Yeah, this would be better. But, it might not matter now.

Based on the discussion in the other patch, I am considering printing
the source names rather than the raw bitmap.