linux-kernel - Re: [PATCH] mmap: Remove unused events vma_mas_szero and vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ddc95091-f43a-4c3d-baa1-058b19d477d6@oracle.com>
Date: Thu, 5 Jun 2025 16:31:20 -0400
From: Sidhartha Kumar <sidhartha.kumar@...cle.com>
To: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>,
        Linux Trace Kernel <linux-trace-kernel@...r.kernel.org>,
        linux-mm@...ck.org
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH] mmap: Remove unused events vma_mas_szero and vma_store

On 6/5/25 4:19 PM, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> When the __vma_adjust() was converted to use the vma iterator it removed
> the functions vma_mas_store() and vma_mas_remove(). These functions called
> the tracepoints trace_vma_mas_store() and trace_vma_mas_szero()
> respectively. The calls to these tracepoints were removed but the trace
> events that created the tracepoints were not removed. Each trace event can
> take up to 5K of memory, and it is allocated regardless of if they are
> called or not.
> 
> Remove the unused trace events.
> 
> Link: https://lore.kernel.org/all/20250529130138.544ffec4@gandalf.local.home/
> 
> Fixes: fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator")
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>


Reviewed-by: Sidhartha Kumar <sidhartha.kumar@...cle.com>

> ---
>   include/trace/events/mmap.h | 52 -------------------------------------
>   1 file changed, 52 deletions(-)
> 
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index f8d61485de16..ee2843a5daef 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -43,58 +43,6 @@ TRACE_EVENT(vm_unmapped_area,
>   		__entry->align_offset)
>   );
>   
> -TRACE_EVENT(vma_mas_szero,
> -	TP_PROTO(struct maple_tree *mt, unsigned long start,
> -		 unsigned long end),
> -
> -	TP_ARGS(mt, start, end),
> -
> -	TP_STRUCT__entry(
> -			__field(struct maple_tree *, mt)
> -			__field(unsigned long, start)
> -			__field(unsigned long, end)
> -	),
> -
> -	TP_fast_assign(
> -			__entry->mt		= mt;
> -			__entry->start		= start;
> -			__entry->end		= end;
> -	),
> -
> -	TP_printk("mt_mod %p, (NULL), SNULL, %lu, %lu,",
> -		  __entry->mt,
> -		  (unsigned long) __entry->start,
> -		  (unsigned long) __entry->end
> -	)
> -);
> -
> -TRACE_EVENT(vma_store,
> -	TP_PROTO(struct maple_tree *mt, struct vm_area_struct *vma),
> -
> -	TP_ARGS(mt, vma),
> -
> -	TP_STRUCT__entry(
> -			__field(struct maple_tree *, mt)
> -			__field(struct vm_area_struct *, vma)
> -			__field(unsigned long, vm_start)
> -			__field(unsigned long, vm_end)
> -	),
> -
> -	TP_fast_assign(
> -			__entry->mt		= mt;
> -			__entry->vma		= vma;
> -			__entry->vm_start	= vma->vm_start;
> -			__entry->vm_end		= vma->vm_end - 1;
> -	),
> -
> -	TP_printk("mt_mod %p, (%p), STORE, %lu, %lu,",
> -		  __entry->mt, __entry->vma,
> -		  (unsigned long) __entry->vm_start,
> -		  (unsigned long) __entry->vm_end
> -	)
> -);
> -
> -
>   TRACE_EVENT(exit_mmap,
>   	TP_PROTO(struct mm_struct *mm),
>