linux-kernel - Re: [GIT PULL] Rust for 6.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEEjzTMJm7YzS1Ks@Mac.home>
Date: Wed, 4 Jun 2025 21:57:49 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, rust-for-linux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] Rust for 6.16

On Wed, Jun 04, 2025 at 09:18:36PM -0700, Linus Torvalds wrote:
> On Wed, 4 Jun 2025 at 19:54, Miguel Ojeda <ojeda@...nel.org> wrote:
> >
> > There are a few conflicts, including semantic ones, but they are all
> > easy to apply. The resolutions in the latest linux-next are fine; I also
> > did a test merge -- please check either to catch the semantic ones
> 
> Hmm. I don't understand why the suggested merge adds those
> 
>         let self_ptr: *mut Opaque<bindings::drm_gem_object> = self_ptr.cast();
> 
>         let ptr: *mut Opaque<bindings::drm_gem_object> = obj.cast();
> 
> cases to rust/kernel/drm/gem/mod.rs, and it built cleanly for me
> without those changes, but that may be because my build doesn't
> trigger this.
> 
> But in the name of safety, and because I didn't understand that
> change, I modified my merge to do what you did.
> 

FWIW, I think this thread has the explanation:

	https://lore.kernel.org/regressions/CANiq72mFL4dn+0JppLLfxyKnM+xYwKeduFw2j07hUfxWVVHdUw@mail.gmail.com/

I believe these changes are needed because in commit b20fbbc08a36
("rust: check type of `$ptr` in `container_of!`"), we enabled the
checking for `container_of!(ptr, struct, field)` that `ptr` must be the
same type of `&struct->field`. But the drm/gem code is added from a
different repo (probably the nova tree), so the adjustment has to be
done in a merge. Miguel can keep me honest on this one ;-)

Regards,
Boqun

>                  Linus