linux-kernel - Re: [PATCH 1/2] dt-bindings: input: goodix,gt9916: Document stylus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0365ffe2-82c6-41d1-ab39-17fe4642bebc@kernel.org>
Date: Thu, 5 Jun 2025 07:54:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengyu Luo <mitltlatltl@...il.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
 Kees Cook <kees@...nel.org>, Dan Williams <dan.j.williams@...el.com>,
 Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Dionna Amalie Glaze <dionnaglaze@...gle.com>,
 Yury Norov <yury.norov@...il.com>, Filipe Manana <fdmanana@...e.com>,
 Len Brown <len.brown@...el.com>, Eric Biggers <ebiggers@...gle.com>,
 pengdonglin <pengdonglin@...omi.com>, Luo Jie <quic_luoj@...cinc.com>,
 Neil Armstrong <neil.armstrong@...aro.org>
Cc: Charles Wang <charles.goodix@...il.com>, linux-input@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: goodix,gt9916: Document stylus
 support

On 05/06/2025 07:48, Pengyu Luo wrote:
> Document stylus support. Optional support for DT properties:
>   - `goodix,stylus-enable`
>   - `goodix,stylus-pressure-level`
>   - `goodix,physical-x`
>   - `goodix,physical-y`
> 
> Signed-off-by: Pengyu Luo <mitltlatltl@...il.com>
> ---
>  .../input/touchscreen/goodix,gt9916.yaml      | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
> index c40d92b7f..e5476ea36 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml
> @@ -44,6 +44,27 @@ properties:
>    touchscreen-size-y: true
>    touchscreen-swapped-x-y: true
>  
> +  goodix,stylus-enable:
> +    type: boolean
> +    description:
> +      Indicates that stylus (pen) functionality is enabled. If present,

Looks like deducible from the compatible.

> +      the driver will initialize stylus-specific input reporting.

What if my driver does something else? Shall we change the binding? No.

> +
> +  goodix,physical-x:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Physical width of the touchscreen in millimeters.

No, use existing input properties.

> +
> +  goodix,physical-y:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Physical height of the touchscreen in millimeters.
> +
> +  goodix,stylus-pressure-level:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Number of discrete pressure levels supported by the stylus.
> +      The reported ABS_PRESSURE range will be 0 to
> +      (goodix,stylus-pressure-level - 1).

Use existing input properties.



Best regards,
Krzysztof