linux-kernel - Re: [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aEEzZjfLVUW1kyC9@smile.fi.intel.com>
Date: Thu, 5 Jun 2025 09:04:22 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	Sergiu Cuciurean <sergiu.cuciurean@...log.com>, nuno.sa@...log.com,
	Michael.Hennerich@...log.com, marcelo.schmitt@...log.com,
	jic23@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, marcelo.schmitt1@...il.com,
	linus.walleij@...aro.org, brgl@...ev.pl, lgirdwood@...il.com,
	broonie@...nel.org, jonath4nns@...il.com, dlechner@...libre.com,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v10 07/12] iio: adc: ad7768-1: Add GPIO controller support

On Wed, Jun 04, 2025 at 04:36:43PM -0300, Jonathan Santos wrote:
> From: Sergiu Cuciurean <sergiu.cuciurean@...log.com>
> 
> The AD7768-1 has the ability to control other local hardware (such as gain
> stages),to power down other blocks in the signal chain, or read local
> status signals over the SPI interface.
> 
> Add direct mode conditional locks in the gpio callbacks to prevent register

GPIO

> access when the device is in buffered mode.
> 
> This change exports the AD7768-1's four gpios and makes them accessible

GPIOs

> at an upper layer.

...

I haven't seen in the commit message nor in the comments why GPIO regmap can't
be used. (No need to resend, just reply here, but keep in mind in case of a new
version of the series.)

-- 
With Best Regards,
Andy Shevchenko