linux-kernel - Re: [RFC v4 09/18] page_pool: rename __page_pool_put_page() to __page_pool_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78cc50c9-052b-446f-bd27-9eea73386e60@gmail.com>
Date: Thu, 5 Jun 2025 11:39:36 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Byungchul Park <byungchul@...com>, willy@...radead.org,
 netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 kernel_team@...ynix.com, kuba@...nel.org, almasrymina@...gle.com,
 ilias.apalodimas@...aro.org, harry.yoo@...cle.com, hawk@...nel.org,
 akpm@...ux-foundation.org, davem@...emloft.net, john.fastabend@...il.com,
 andrew+netdev@...n.ch, toke@...hat.com, tariqt@...dia.com,
 edumazet@...gle.com, pabeni@...hat.com, saeedm@...dia.com, leon@...nel.org,
 ast@...nel.org, daniel@...earbox.net, david@...hat.com,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 rppt@...nel.org, surenb@...gle.com, mhocko@...e.com, horms@...nel.org,
 linux-rdma@...r.kernel.org, bpf@...r.kernel.org, vishal.moola@...il.com
Subject: Re: [RFC v4 09/18] page_pool: rename __page_pool_put_page() to
 __page_pool_put_netmem()

On 6/5/25 11:35, Pavel Begunkov wrote:
> On 6/4/25 03:52, Byungchul Park wrote:
>> Now that __page_pool_put_page() puts netmem, not struct page, rename it
>> to __page_pool_put_netmem() to reflect what it does.
> 
> Reviewed-by: Pavel Begunkov <asml.silence@...il.com>

Actually, the function is for non-mp struct pages only, would make
sense to use struct page instead. I'd even argue that it's better
to change the argument to struct page *.

-- 
Pavel Begunkov